Skip to content

Don't include closing quotes in value #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't include closing quotes in value #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49e0a7c
Don't include closing quotes in value
mendelmaleh Aug 13, 2024
7e10929
Add quoted string test
mendelmaleh Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion unmarshal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ func (d *Decoder) unmarshal(val reflect.Value, line string) error {
}
case len(v) >= 2 && strings.HasPrefix(v, Wrapper) && strings.HasSuffix(v, Wrapper):
// (1) .. ,"", .. (2) ..," text text ", ..
combined = append(combined, v[1:len(v)])
combined = append(combined, v[1:len(v)-1])
merged = ""
case strings.HasPrefix(v, Wrapper):
// .. ," text, more text", .. (1st part)
Expand Down
15 changes: 15 additions & 0 deletions unmarshal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ const (
CsvWithHeader = `s,i,f,b
Hello,42,23.45,true`
CsvWithoutHeader = `Hello,true,42,23.45`
CsvQuoted = `"Hello",true,42,23.45`
CsvWhitespace = ` Hello , true , 42 , 23.45`
CsvSemicolon = `Hello;true;42;23.45`
CsvComment = `# Comment line
Expand Down Expand Up @@ -317,6 +318,20 @@ func TestUnmarshalWithoutHeader(t *testing.T) {
CheckA(t, a[0], A1)
}

func TestUnmarshalQuoted(t *testing.T) {
r := bytes.NewReader([]byte(CsvQuoted))
dec := NewDecoder(r).Header(false)
a := make([]*A, 0)
if err := dec.Decode(&a); err != nil {
t.Error(err)
}
if len(a) != 1 {
t.Errorf("invalid record count, got=%d expected=%d", len(a), 1)
return
}
CheckA(t, a[0], A1)
}

func TestUnmarshalRecords(t *testing.T) {
r := bytes.NewReader([]byte(CsvWithHeader))
dec := NewDecoder(r)
Expand Down