Use renamed column name in $partition table in Iceberg #24069
+147
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Nov 8, 2024
| @@ -278,4 +278,15 @@ public void testNestedFieldChangePartitionTransform() | |||
| assertThat(monthPartitionedFiles).hasSize(2); | |||
| assertUpdate("DROP TABLE " + tableName); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testPartitionRename() | |||
There was a problem hiding this comment.
We usually use BaseIcebergSystemTables for testing system tables.
|
|
||
| assertQuery("SELECT partition.par_renamed FROM \"" + tableName + "$partitions\"", "VALUES 11"); | ||
| assertUpdate("DROP TABLE " + tableName); | ||
| } |
There was a problem hiding this comment.
Could you please add some tests?
- partitioning by transforms, e.g. bucket
- partitioning by nested field
There was a problem hiding this comment.
good point.
this will cause nested field to return field name only.
Thinking how to rebuild the column.field ...
There was a problem hiding this comment.
Updated the logic with a new partitionNameTransform as single place source of truth on partition column naming.
Now both nested identify and bucketing tranforms are handled as new names.
ebyhr
changed the title
jinyangli34
force-pushed
the
jinyang-iceberg_partition_rename
branch
4 times, most recently
from
81bc086
to
3199969
Compare
jinyangli34
force-pushed
the
jinyang-iceberg_partition_rename
branch
from
3199969
to
9e13de3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trino use the
field.name()as partition name when building Iceberg$partitiontable.After a partition column rename, the
$partitiontable returns old partition column name that no longer exists.Fix the logic to use updated partition column name to keep it consistent with new schema.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: