JDBC Client: fix Exception Handling Bug in TrinoResultSet #25725
Conversation
…was not triggered when a query failed due to missing partition filters.
There was a problem hiding this comment.
Can we reword the commit message as mentioned here https://trino.io/development/process#pull-request-and-commit-guidelines-
| private static class ExtraCredentialsSystemTable | ||
| implements SystemTable | ||
| { |
There was a problem hiding this comment.
Do we need this System table ?
|
|
||
| @TestInstance(PER_CLASS) | ||
| @Execution(CONCURRENT) | ||
| public class TestJdbcPartitionFilterRequired |
There was a problem hiding this comment.
Is the issue is very specific to PartitionFilter for hive ? If it is a race condition then it should be seen by other connectors as well.
|
|
||
| @TestInstance(PER_CLASS) | ||
| @Execution(CONCURRENT) | ||
| public class TestJdbcPartitionFilterRequired |
There was a problem hiding this comment.
Please follow the guideline: Test classes should be defined as package-private and final.
| } | ||
|
|
||
| @Test | ||
| public void testFilterRequiredPartitions() |
There was a problem hiding this comment.
Please follow the guideline: Test methods should be defined as package-private.
| @@ -129,7 +129,7 @@ private static List<Column> getColumns(StatementClient client, Consumer<QuerySta | |||
| QueryStatusInfo results = client.currentStatusInfo(); | |||
| progressCallback.accept(QueryStats.create(results.getId(), results.getStats())); | |||
| List<Column> columns = results.getColumns(); | |||
| if (columns != null) { | |||
| if (columns != null && !results.getStats().getState().equals("FAILED")) { | |||
There was a problem hiding this comment.
Do you know how does this get empty columns? @wendigo
I think it's a bug that should fix in the place that return empty columns
| ResultSet resultSet = statement.getResultSet(); | ||
| assertThat(resultSet.next()).isTrue(); | ||
| } | ||
| }).isInstanceOf(SQLException.class); |
There was a problem hiding this comment.
What's the error message ?
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
Description
When using the configuration setting hive.query-partition-filter-required=true in Trino's JDBC client, a SQLException is expected to be thrown when a query is missing a required partition column. However, no error was raised in this case.
The root cause is that when a query fails due to a missing partition filter, results.getColumns() returns an empty List object (i.e., a list with a size of 0). As a result, the exception handling logic that depends on the presence of columns was not triggered as expected.
This fix ensures that when the query execution result is FAILED, the column retrieval will also fail accordingly, allowing the exception handling code to run as intended.
Change Summary