Skip to content

Add more test cases for json_query function#25783

Merged
kasiafi merged 1 commit intotrinodb:masterfrom
XavieLee:update/testcase/json_query
May 30, 2025
Merged

Add more test cases for json_query function#25783
kasiafi merged 1 commit intotrinodb:masterfrom
XavieLee:update/testcase/json_query

Conversation

@XavieLee
Copy link
Copy Markdown
Member

@XavieLee XavieLee commented May 13, 2025

Description

Add more test cases for json_query function to help developer understand the usage of this function.

Additional context and related issues

Fixes #25545

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Copy link
Copy Markdown
Member

@kasiafi kasiafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two minor comments.

Comment thread core/trino-main/src/test/java/io/trino/sql/query/TestJsonQueryFunction.java Outdated
Comment thread core/trino-main/src/test/java/io/trino/sql/query/TestJsonQueryFunction.java Outdated
Comment thread core/trino-main/src/test/java/io/trino/sql/query/TestJsonQueryFunction.java Outdated
Comment thread core/trino-main/src/test/java/io/trino/sql/query/TestJsonQueryFunction.java Outdated
Comment thread core/trino-main/src/test/java/io/trino/sql/query/TestJsonQueryFunction.java Outdated
@XavieLee XavieLee force-pushed the update/testcase/json_query branch from 1f30d93 to 47d6da0 Compare May 24, 2025 06:20
@XavieLee
Copy link
Copy Markdown
Member Author

@chenjian2664 @kasiafi All done, thanks!

@XavieLee XavieLee force-pushed the update/testcase/json_query branch from 47d6da0 to 69bc91e Compare May 24, 2025 06:26
@kasiafi kasiafi merged commit 3da3772 into trinodb:master May 30, 2025
93 checks passed
@kasiafi
Copy link
Copy Markdown
Member

kasiafi commented May 30, 2025

@chenjian2664 merged, thanks!

@github-actions github-actions Bot added this to the 476 milestone May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

No description of json_query($..) behavior in documentation

3 participants