Add register_table procedure usage instructions #25784
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
reviewed
May 19, 2025
| @@ -555,6 +555,8 @@ To prevent unauthorized users from accessing data, this procedure is disabled by | |||
| default. The procedure is enabled only when | |||
| `iceberg.register-table-procedure.enabled` is set to `true`. | |||
|
|
|||
| Avoid registering multiple tables with the same location. | |||
There was a problem hiding this comment.
Reasoning behind the recommandation is missing
There was a problem hiding this comment.
@findinpath I follow ebyhr's suggestion and remove it before. #25536 (comment)
now I have re-described it, please help review again, thanks~
There was a problem hiding this comment.
I wasn't suggesting removing the reason - the removed part isn't the "reason". It's just a protection rule.
XavieLee
force-pushed
the
update/doc/register_table
branch
from
b6abfff to
a38189f
Compare
ebyhr
reviewed
May 23, 2025
| @@ -555,6 +555,8 @@ To prevent unauthorized users from accessing data, this procedure is disabled by | |||
| default. The procedure is enabled only when | |||
| `iceberg.register-table-procedure.enabled` is set to `true`. | |||
|
|
|||
| Ensure tables are registered using their prior storage path, and avoid associating multiple tables with identical locations. | |||
There was a problem hiding this comment.
"Ensure tables are registered using their prior storage path"
Users don't have to ensure that. The procedure blocks such execution either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
People try to register tables in a different location and face query failures later, add description for this function.
Additional context and related issues
#16105
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.