Skip to content

Conversation

@etolbakov
Copy link
Member

@etolbakov etolbakov commented Oct 20, 2025

Description

I've noticed that exchange.max-page-storage-size property exists in the code but is not mentioned in the Exchange manager docs.
I assume that it's just missing/overlooked. Happy to provide a small fix.

Fixes #27023

Release notes

( x ) This is not user-visible or is docs only, and no release notes are required.

Summary by Sourcery

Documentation:

  • Add the exchange.max-page-storage-size property to the Exchange manager section with its description and default value

@cla-bot cla-bot bot added the cla-signed label Oct 20, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 20, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update the fault-tolerant execution docs by adding the missing exchange.max-page-storage-size property with its description, default, and scope, and correct formatting for related entries.

File-Level Changes

Change Details Files
Add documentation for exchange.max-page-storage-size
  • Insert new bullet for exchange.max-page-storage-size
  • Describe max-page size semantics and default value
  • Specify default as 16MB and scope as Any
docs/src/main/sphinx/admin/fault-tolerant-execution.md
Correct formatting of default values
  • Replace double backticks around 1GB with single backticks
  • Align list indentation for consistency
docs/src/main/sphinx/admin/fault-tolerant-execution.md

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the docs label Oct 20, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@etolbakov
Copy link
Member Author

@ebyhr could you please take a look at this docs update when you have a spare minute?

@etolbakov
Copy link
Member Author

to ruin the first impression completely I've messed up during the update. Fixing

@ebyhr ebyhr force-pushed the fix-exchange-manager-docs branch from 8c3db2a to 2e31331 Compare October 21, 2025 02:25
@ebyhr ebyhr requested review from losipiuk and wendigo October 21, 2025 02:25
@ebyhr ebyhr force-pushed the fix-exchange-manager-docs branch from 47e04df to a9adfb8 Compare October 21, 2025 23:07
@ebyhr
Copy link
Member

ebyhr commented Oct 22, 2025

@etolbakov You don't need to rebase unless there is a conflict. Also, please use "rebase" instead of "merge" from next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Exchange manager setting is missing in the docs

2 participants