Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project refactor #130

Merged
merged 22 commits into from
Jan 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/heimdallr.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: Heimdallr

on: push

jobs:
Build_and_Test:

runs-on: macos-latest

steps:
- uses: actions/checkout@v2
- name: Build
run: swift build --build-tests --disable-automatic-resolution -v
- name: Run tests
run: swift test --disable-automatic-resolution -v
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
## Build generated
build/
DerivedData
.build

## Various settings
*.pbxuser
Expand Down
15 changes: 0 additions & 15 deletions .gitmodules

This file was deleted.

1 change: 0 additions & 1 deletion .swift-version

This file was deleted.

7 changes: 7 additions & 0 deletions .swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

105 changes: 105 additions & 0 deletions .swiftpm/xcode/xcshareddata/xcschemes/Heimdallr.xcscheme
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1240"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES">
<BuildActionEntries>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "YES"
buildForArchiving = "YES"
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "Heimdallr_HeimdallrTests"
BuildableName = "Heimdallr_HeimdallrTests"
BlueprintName = "Heimdallr_HeimdallrTests"
ReferencedContainer = "container:">
</BuildableReference>
</BuildActionEntry>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "YES"
buildForArchiving = "YES"
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "Heimdallr"
BuildableName = "Heimdallr"
BlueprintName = "Heimdallr"
ReferencedContainer = "container:">
</BuildableReference>
</BuildActionEntry>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "NO"
buildForArchiving = "NO"
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "HeimdallrTests"
BuildableName = "HeimdallrTests"
BlueprintName = "HeimdallrTests"
ReferencedContainer = "container:">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
</BuildAction>
<TestAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES">
<Testables>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "HeimdallrTests"
BuildableName = "HeimdallrTests"
BlueprintName = "HeimdallrTests"
ReferencedContainer = "container:">
</BuildableReference>
</TestableReference>
</Testables>
</TestAction>
<LaunchAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
launchStyle = "0"
useCustomWorkingDirectory = "NO"
ignoresPersistentStateOnLaunch = "NO"
debugDocumentVersioning = "YES"
debugServiceExtension = "internal"
allowLocationSimulation = "YES">
</LaunchAction>
<ProfileAction
buildConfiguration = "Release"
shouldUseLaunchSchemeArgsEnv = "YES"
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "Heimdallr_HeimdallrTests"
BuildableName = "Heimdallr_HeimdallrTests"
BlueprintName = "Heimdallr_HeimdallrTests"
ReferencedContainer = "container:">
</BuildableReference>
</MacroExpansion>
</ProfileAction>
<AnalyzeAction
buildConfiguration = "Debug">
</AnalyzeAction>
<ArchiveAction
buildConfiguration = "Release"
revealArchiveInOrganizer = "YES">
</ArchiveAction>
</Scheme>
8 changes: 3 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
You're interested in contributing to this project, that's awesome!

## Dependencies
The Xcode project is only included to support Carthage. You can still edit the files from the included Xcode project, but it does not include the tests, so it is recommended to open the root folder directly in Xcode so that it can recognize it as a Swift Package and allow running the tests.

We are using [Carthage](https://github.com/Carthage/Carthage) to manage dependencies without relying on it at build-time by integrating dependencies as Git Submodules. If you want to update a dependency, please change the corresponding `Cartfile` and run:
## Dependencies

```sh
carthage update --use-submodules --no-build <dependency>
```
There is only one dependency in the project, which is [OHHTTPStubs](https://github.com/AliSoftware/OHHTTPStubs). This is only used for testing.
2 changes: 0 additions & 2 deletions Cartfile

This file was deleted.

8 changes: 0 additions & 8 deletions Cartfile.private

This file was deleted.

5 changes: 0 additions & 5 deletions Cartfile.resolved

This file was deleted.

1 change: 0 additions & 1 deletion Carthage/Checkouts/Nimble
Submodule Nimble deleted from 43304b
1 change: 0 additions & 1 deletion Carthage/Checkouts/OHHTTPStubs
Submodule OHHTTPStubs deleted from 543182
1 change: 0 additions & 1 deletion Carthage/Checkouts/Quick
Submodule Quick deleted from 94df9b
1 change: 0 additions & 1 deletion Carthage/Checkouts/Result
Submodule Result deleted from 2ca499
1 change: 0 additions & 1 deletion Carthage/Checkouts/xcconfigs
Submodule xcconfigs deleted from d0f899
36 changes: 15 additions & 21 deletions Heimdallr.podspec
Original file line number Diff line number Diff line change
@@ -1,31 +1,25 @@
Pod::Spec.new do |spec|
spec.name = 'Heimdallr'
spec.version = '3.7.0'
spec.name = "Heimdallr"
spec.version = "4.0.0"
spec.authors = {
'trivago' => '[email protected]'
"trivago" => "[email protected]"
}
spec.social_media_url = 'https://twitter.com/trivago'
spec.social_media_url = "https://twitter.com/trivago"
spec.license = {
:type => 'Apache License, Version 2.0',
:file => 'LICENSE'
:type => "Apache License, Version 2.0",
:file => "LICENSE"
}
spec.homepage = 'https://github.com/trivago/Heimdallr.swift'
spec.homepage = "https://github.com/trivago/Heimdallr.swift"
spec.source = {
:git => 'https://github.com/trivago/Heimdallr.swift.git',
:git => "https://github.com/trivago/Heimdallr.swift.git",
:tag => spec.version.to_s
}
spec.summary = 'Easy to use OAuth 2 library, written in Swift'
spec.description = 'Heimdallr is an OAuth 2.0 client specifically designed for easy usage. It currently supports the resource owner password credentials grant flow, refreshing an access token as well as extension grants.'

spec.summary = "Easy to use OAuth 2 library, written in Swift"
spec.description = "Heimdallr is an OAuth 2.0 client specifically designed for easy usage. It currently supports the resource owner password credentials grant flow, refreshing an access token as well as extension grants."

spec.ios.deployment_target = '9.0'
spec.osx.deployment_target = '10.10'
spec.swift_version = '5.0'

spec.default_subspec = 'Core'

spec.subspec 'Core' do |subspec|
subspec.framework = 'Foundation'

subspec.source_files = 'Heimdallr/*.swift'
end
spec.platforms = { :ios => "11.0", :osx => "10.10" }
spec.swift_version = "5.3"

spec.source_files = "Sources/Heimdallr/*.swift"
end
Loading
Loading