Variable string #60
Open
Variable string #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the "requestedLength" arguments and use allocatable strings now that these are available.
The readme is updated. Add users guide in markdown format and remove latex version.
Remove more dependences on fixed length character variables.
Add links to examples. Add info about optData functionality to the documentation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 94.50% 94.50%
=======================================
Files 32 32
Lines 2820 2820
=======================================
Hits 2665 2665
Misses 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewwinters5000
requested changes
Apr 15, 2025
Align code blocks.
More code formatting. Fix link to Apple.
Caught a couple more alignment errors.
andrewwinters5000
requested changes
Apr 16, 2025
Fix an escape for a single underscore.
andrewwinters5000
approved these changes
Apr 16, 2025
|
Right. Let's do your doc update PR first, since it's simple. Then let's discuss how to coordinate the HOHQMesh update. |
|
Yes, I think that is the best order of operations. Then we can make a new release of HOHQMesh that contains the FToL changes and add an appropriate |
Fix code examples formatting.
Fix code example object names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When FTOL was first written, gfortran did not have allocatable strings implemented yet, so a workaround was used where a requested length parameter would set the string length for returns from stringValue. This is now removed (finally) since fortran includes the functionality now.