WIP: Sc/p4est view coupled hanging nodes#2598
Draft
SimonCan wants to merge 124 commits into
Draft
Conversation
Contributor
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## sc/p4est-view-coupled-enhanced #2598 +/- ##
=================================================================
Coverage ? 91.87%
=================================================================
Files ? 570
Lines ? 44734
Branches ? 0
=================================================================
Hits ? 41095
Misses ? 3639
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…led-hanging-nodes
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…led-hanging-nodes
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Use coordinate-based cell ID selection so the ring/center split works at any initial_refinement_level, and add mesh_equations_solver_cache and analyze_convergence dispatches for SemidiscretizationCoupledP4est so that convergence_test produces a proper EOC table.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…led-hanging-nodes
| equations, dg::DGSEM, cache, | ||
| args...; normalize = true) where {Func} | ||
| return integrate_via_indices(func, trixi_backend(u), u, mesh, equations, dg, cache, | ||
| return integrate_via_indices(func, trixi_backend(_u), _u, mesh, equations, dg, cache, |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| return integrate_via_indices(func, trixi_backend(_u), _u, mesh, equations, dg, cache, | |
| return integrate_via_indices(func, trixi_backend(_u), _u, mesh, equations, dg, | |
| cache, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added capability of coupling pest mesh views with hanging/non-conforming nodes.
Convergence test for examples/p4est_2d_dgsem/elixir_advection_coupled.jl:
This PR has had significant contributions by the LLM Claude.