Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JuliaGPU Buildkite CI for GPU tests #723

Merged
merged 48 commits into from
Mar 6, 2025
Merged

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented Feb 20, 2025

Based on #689.

I added a GPU test suite and configured Buildkite on the public JuliaGPU runners.
These resources are very limited, so we should not start a build on every single push. Instead, I added a GitHub action to trigger GPU CI by commenting /run-gpu-tests on a PR. About 30 seconds later, the Buildkite jobs should appear in the list of checks for the PR. Also, every push on main will trigger a GPU CI build.
Note that especially for AMD the lack of resources requires us to wait for about an hour for a free runner.

While writing the GPU tests, I also found the following problems (and fixed some of them):

@efaulhaber efaulhaber force-pushed the ef/juliagpu-buildkite branch from d483eae to 486af04 Compare February 21, 2025 09:36
@efaulhaber efaulhaber self-assigned this Feb 21, 2025
@efaulhaber efaulhaber added gpu testing Improvements or additions to tests labels Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 82.08955% with 12 lines in your changes missing coverage. Please review.

Project coverage is 70.25%. Comparing base (aa6475b) to head (49f826c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/preprocessing/particle_packing/system.jl 0.00% 2 Missing ⚠️
...rc/schemes/fluid/entropically_damped_sph/system.jl 92.30% 2 Missing ⚠️
...rc/schemes/solid/discrete_element_method/system.jl 0.00% 2 Missing ⚠️
src/general/system.jl 0.00% 1 Missing ⚠️
...chemes/boundary/monaghan_kajtar/monaghan_kajtar.jl 66.66% 1 Missing ⚠️
src/schemes/boundary/system.jl 80.00% 1 Missing ⚠️
src/schemes/fluid/transport_velocity.jl 50.00% 1 Missing ⚠️
...s/fluid/weakly_compressible_sph/state_equations.jl 50.00% 1 Missing ⚠️
src/setups/extrude_geometry.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
+ Coverage   70.22%   70.25%   +0.02%     
==========================================
  Files          96       96              
  Lines        6001     6017      +16     
==========================================
+ Hits         4214     4227      +13     
- Misses       1787     1790       +3     
Flag Coverage Δ
unit 70.25% <82.08%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sloede
Copy link
Member

sloede commented Feb 27, 2025

With JuliaConcurrent/Atomix.jl#52 merged, at least the oneAPI should be able to run now...

@efaulhaber efaulhaber closed this Feb 27, 2025
@efaulhaber efaulhaber reopened this Feb 27, 2025
@efaulhaber
Copy link
Member Author

With JuliaConcurrent/Atomix.jl#52 merged, at least the oneAPI should be able to run now...

It's still sh*t and gives a segfault in the first test.

@efaulhaber
Copy link
Member Author

/run-gpu-tests

1 similar comment
@efaulhaber
Copy link
Member Author

/run-gpu-tests

@efaulhaber
Copy link
Member Author

/run-gpu-tests

@efaulhaber
Copy link
Member Author

/run-gpu-tests

3 similar comments
@efaulhaber
Copy link
Member Author

/run-gpu-tests

@efaulhaber
Copy link
Member Author

/run-gpu-tests

@efaulhaber
Copy link
Member Author

/run-gpu-tests

@efaulhaber
Copy link
Member Author

/run-gpu-tests

@efaulhaber
Copy link
Member Author

/run-gpu-tests

@efaulhaber efaulhaber marked this pull request as ready for review March 6, 2025 08:48
@efaulhaber efaulhaber requested review from LasNikas and svchb March 6, 2025 08:48
@efaulhaber efaulhaber mentioned this pull request Mar 6, 2025
10 tasks
@efaulhaber
Copy link
Member Author

/run-gpu-tests

Copy link
Collaborator

@svchb svchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlight support for GPUs by adding it to readme.md

@efaulhaber efaulhaber requested a review from svchb March 6, 2025 13:34
@LasNikas LasNikas merged commit 8ab9e4d into main Mar 6, 2025
14 checks passed
@LasNikas LasNikas deleted the ef/juliagpu-buildkite branch March 6, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpu testing Improvements or additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants