Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEM improvements #739

Closed
wants to merge 0 commits into from
Closed

DEM improvements #739

wants to merge 0 commits into from

Conversation

svchb
Copy link
Collaborator

@svchb svchb commented Mar 28, 2025

No description provided.

@svchb svchb added the enhancement New feature or request label Mar 28, 2025
@svchb svchb self-assigned this Mar 28, 2025
@svchb svchb marked this pull request as draft March 28, 2025 09:48
@svchb svchb requested review from efaulhaber and LasNikas March 28, 2025 13:48
@svchb svchb marked this pull request as ready for review March 28, 2025 14:30
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 56.32184% with 38 lines in your changes missing coverage. Please review.

Project coverage is 70.08%. Comparing base (f8ea678) to head (209f629).

Files with missing lines Patch % Lines
src/schemes/solid/discrete_element_method/rhs.jl 0.00% 26 Missing ⚠️
...es/solid/discrete_element_method/contact_models.jl 80.48% 8 Missing ⚠️
src/schemes/boundary/system.jl 0.00% 2 Missing ⚠️
...rc/schemes/solid/discrete_element_method/system.jl 93.75% 1 Missing ⚠️
test/systems/dem_system.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
+ Coverage   69.98%   70.08%   +0.09%     
==========================================
  Files          96       98       +2     
  Lines        6170     6214      +44     
==========================================
+ Hits         4318     4355      +37     
- Misses       1852     1859       +7     
Flag Coverage Δ
unit 70.08% <56.32%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb svchb requested a review from Copilot April 4, 2025 21:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (9)
  • examples/dem/rectangular_tank_2d.jl: Language not supported
  • src/TrixiParticles.jl: Language not supported
  • src/schemes/boundary/system.jl: Language not supported
  • src/schemes/solid/discrete_element_method/contact_models.jl: Language not supported
  • src/schemes/solid/discrete_element_method/discrete_element_method.jl: Language not supported
  • src/schemes/solid/discrete_element_method/rhs.jl: Language not supported
  • src/schemes/solid/discrete_element_method/system.jl: Language not supported
  • test/systems/dem_system.jl: Language not supported
  • test/test_util.jl: Language not supported
Comments suppressed due to low confidence (2)

test/Project.toml:16

  • [nitpick] Verify that the dependency identifier for StaticArrays conforms to the project standards since the ID format is different from typical version numbers.
+StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"

test/Project.toml:29

  • Ensure the version constraint '1' for StaticArrays in the [compat] section is intended and aligns with semantic versioning guidelines; consider a more explicit constraint format if needed.
+StaticArrays = "1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant