Skip to content

Fix FSI-Open Boundary interaction and add variable material parameters #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 4, 2025

Conversation

LasNikas
Copy link
Collaborator

No description provided.

@LasNikas LasNikas added the bug Something isn't working label Mar 30, 2025
@LasNikas LasNikas requested review from svchb and efaulhaber March 30, 2025 10:48
@LasNikas LasNikas self-assigned this Mar 30, 2025
@LasNikas LasNikas added the enhancement New feature or request label Mar 30, 2025
Copy link

codecov bot commented Mar 30, 2025

Codecov Report

Attention: Patch coverage is 56.25000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 69.87%. Comparing base (f8ea678) to head (46c98a1).

Files with missing lines Patch % Lines
...chemes/solid/total_lagrangian_sph/penalty_force.jl 0.00% 5 Missing ⚠️
src/general/semidiscretization.jl 0.00% 4 Missing ⚠️
src/schemes/solid/total_lagrangian_sph/system.jl 85.00% 3 Missing ⚠️
src/schemes/boundary/open_boundary/system.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
- Coverage   69.98%   69.87%   -0.12%     
==========================================
  Files          96       96              
  Lines        6170     6187      +17     
==========================================
+ Hits         4318     4323       +5     
- Misses       1852     1864      +12     
Flag Coverage Δ
unit 69.87% <56.25%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LasNikas LasNikas requested a review from svchb April 1, 2025 10:57
@LasNikas LasNikas requested a review from svchb April 1, 2025 11:15
svchb
svchb previously approved these changes Apr 1, 2025
@LasNikas LasNikas requested a review from efaulhaber April 4, 2025 13:21
@LasNikas LasNikas enabled auto-merge (squash) April 4, 2025 13:49
@LasNikas
Copy link
Collaborator Author

LasNikas commented Apr 4, 2025

/run-gpu-tests

@LasNikas LasNikas merged commit 75d816e into trixi-framework:main Apr 4, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants