-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init support for some reward handlers #86
Open
EHAT32
wants to merge
13
commits into
trueagi-io:master
Choose a base branch
from
EHAT32:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some further inspection i figured the problem might be in Python parsing MissionEndedXML and not in MissionEnded part in Java |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently trying to implement reward handlers (RewardForSendingCommand and RewardForTouchingBlockType). I have stumbled upon a problem when rewards should be triggered on the same tick when agent quits the mission. For example, i am running cliff_walking example. Missions ends when agent touches the lava. Thus, mission ends but no reward for sending a command is triggered. The same thing with RewardForTouchingBlockType, at first agent touches the lava, mission ends and no reward for touching lava is triggered.
For the first implementation i uncommented this code in ClientStateMachine.MissionRunningEpisode.sendData() and modified getReward() a bit:
Also, i noticed there's a code for getting rewards with a message of ended mission
I tried to uncomment it as well but at first glance it did nothing. Perhaps, MissionEnded class should be modified or re-implemented? If i got it right, it is a class from Malmo and needs some modifications to work with Vereya.
I would like to get some advices @CICS-Oleg @noskill