Skip to content

Conversation

@linzi-ix
Copy link
Contributor

Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.

@linzi-ix linzi-ix requested a review from a team as a code owner November 20, 2025 13:27
@bugclerk bugclerk changed the title PD-2424-move-ntp-servers-settings PD-2424 / 26.04 / PD-2424-move-ntp-servers-settings Nov 20, 2025
@bugclerk
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 115 issues found in changed files - 18 errors, 2 warnings, 95 suggestions

Changed files with issues:

content/SCALE/SCALEUIReference/SystemSettings/AdvancedSettingsScreen.md (73 issues)

  • Lines 38, 104, 451, 528 - suggestion: Keep sentences under 30 words
  • Lines 38, 187, 438, 440, 479 - error: Don't add '(s)' to a singular noun. Use plural instead.
  • Lines 68, 70, 71, 72, 73, 86, 120, 121, 140, 151, 152, 181, 350, 388, 389, 457, 506, 507, 536 - suggestion: Use active voice instead of passive voice
  • Line 104 - suggestion: Spell out 'MOTD' on first use
  • Lines 121, 181, 480 - suggestion: Don't use language (such as 'disabled') that defines people by their disability.
  • Line 131 - suggestion: Spell out 'TSL' on first use
  • Lines 149, 152, 293 - error: Use 'hostname' instead of 'host name'
  • Lines 219, 451 - suggestion: Try to simplify this sentence.
  • Line 240 - error: Use 'filesystem' instead of 'file system'
  • Lines 490, 536 - error: Use 'Controller 1' instead of 'controller a'

content/SCALE/SCALEUIReference/SystemSettings/GeneralSettingsScreens.md (42 issues)

  • Lines 3, 66 - suggestion: Use Oxford comma before 'and' in lists
  • Lines 64, 66, 106, 120, 139, 140, 160, 194, 197 - suggestion: Use active voice instead of passive voice
  • Line 66 - suggestion: Keep sentences under 30 words
  • Lines 66, 191 - suggestion: Consider 'TrueNAS' instead of 'TrueNAS'
  • Line 74 - suggestion: Use Title Case for headings
  • Line 82 - error: Avoid contractions. Use 'do not' instead of 'don't'.
  • Line 101 - suggestion: Spell out 'EULA' on first use
  • Line 102 - warning: Use first person (such as 'I') sparingly.
  • Line 102 - suggestion: Spell out 'AGREE' on first use
  • Line 134 - warning: Use first person (such as ' I') sparingly.
  • Line 138 - error: Don't add '(s)' to a singular noun. Use plural instead.
  • Line 140 - suggestion: Don't use language (such as 'disabled') that defines people by their disability.
  • Line 161 - suggestion: Avoid using first-person plural (we, us, our)
  • Line 192 - error: Use 'hostname' instead of 'host name'
  • Line 204 - suggestion: Use 'login' instead of 'Log In'
  • Line 204 - error: Use 'login' instead of 'Log In'

🔧 To fix: Review the issues above and update your documentation accordingly.

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 115 issues found in changed files - 18 errors, 2 warnings, 95 suggestions

Changed files with issues:

content/SCALE/SCALEUIReference/SystemSettings/AdvancedSettingsScreen.md (73 issues)

  • Lines 38, 104, 451, 528 - suggestion: Keep sentences under 30 words
  • Lines 38, 187, 438, 440, 479 - error: Don't add '(s)' to a singular noun. Use plural instead.
  • Lines 68, 70, 71, 72, 73, 86, 120, 121, 140, 151, 152, 181, 350, 388, 389, 457, 506, 507, 536 - suggestion: Use active voice instead of passive voice
  • Line 104 - suggestion: Spell out 'MOTD' on first use
  • Lines 121, 181, 480 - suggestion: Don't use language (such as 'disabled') that defines people by their disability.
  • Line 131 - suggestion: Spell out 'TSL' on first use
  • Lines 149, 152, 293 - error: Use 'hostname' instead of 'host name'
  • Lines 219, 451 - suggestion: Try to simplify this sentence.
  • Line 240 - error: Use 'filesystem' instead of 'file system'
  • Lines 490, 536 - error: Use 'Controller 1' instead of 'controller a'

content/SCALE/SCALEUIReference/SystemSettings/GeneralSettingsScreens.md (42 issues)

  • Lines 3, 66 - suggestion: Use Oxford comma before 'and' in lists
  • Lines 64, 66, 106, 120, 139, 140, 160, 194, 197 - suggestion: Use active voice instead of passive voice
  • Line 66 - suggestion: Keep sentences under 30 words
  • Lines 66, 191 - suggestion: Consider 'TrueNAS' instead of 'TrueNAS'
  • Line 74 - suggestion: Use Title Case for headings
  • Line 82 - error: Avoid contractions. Use 'do not' instead of 'don't'.
  • Line 101 - suggestion: Spell out 'EULA' on first use
  • Line 102 - warning: Use first person (such as 'I') sparingly.
  • Line 102 - suggestion: Spell out 'AGREE' on first use
  • Line 134 - warning: Use first person (such as ' I') sparingly.
  • Line 138 - error: Don't add '(s)' to a singular noun. Use plural instead.
  • Line 140 - suggestion: Don't use language (such as 'disabled') that defines people by their disability.
  • Line 161 - suggestion: Avoid using first-person plural (we, us, our)
  • Line 192 - error: Use 'hostname' instead of 'host name'
  • Line 204 - suggestion: Use 'login' instead of 'Log In'
  • Line 204 - error: Use 'login' instead of 'Log In'

🔧 To fix: Review the issues above and update your documentation accordingly.

@DjP-iX
Copy link
Contributor

DjP-iX commented Nov 24, 2025

@linzi-ix This looks fine for NTP servers, did you also review for any other inconsistencies between the docs and the General and Advanced Settings screens?

@linzi-ix
Copy link
Contributor Author

@linzi-ix This looks fine for NTP servers, did you also review for any other inconsistencies between the docs and the General and Advanced Settings screens?

It's been a hot minute since I did this ticket, but I think I did, yes.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Vale Style Guide Issues

📊 Summary: 115 issues found in changed files - 18 errors, 2 warnings, 95 suggestions

Changed files with issues:

content/SCALE/SCALEUIReference/SystemSettings/AdvancedSettingsScreen.md (73 issues)

  • Lines 38, 104, 451, 528 - suggestion: Keep sentences under 30 words
  • Lines 38, 187, 438, 440, 479 - error: Don't add '(s)' to a singular noun. Use plural instead.
  • Lines 68, 70, 71, 72, 73, 86, 120, 121, 140, 151, 152, 181, 350, 388, 389, 457, 506, 507, 536 - suggestion: Use active voice instead of passive voice
  • Line 104 - suggestion: Spell out 'MOTD' on first use
  • Lines 121, 181, 480 - suggestion: Don't use language (such as 'disabled') that defines people by their disability.
  • Line 131 - suggestion: Spell out 'TSL' on first use
  • Lines 149, 152, 293 - error: Use 'hostname' instead of 'host name'
  • Lines 219, 451 - suggestion: Try to simplify this sentence.
  • Line 240 - error: Use 'filesystem' instead of 'file system'
  • Lines 490, 536 - error: Use 'Controller 1' instead of 'controller a'

content/SCALE/SCALEUIReference/SystemSettings/GeneralSettingsScreens.md (42 issues)

  • Lines 3, 66 - suggestion: Use Oxford comma before 'and' in lists
  • Lines 64, 66, 106, 120, 139, 140, 160, 194, 197 - suggestion: Use active voice instead of passive voice
  • Line 66 - suggestion: Keep sentences under 30 words
  • Lines 66, 191 - suggestion: Consider 'TrueNAS' instead of 'TrueNAS'
  • Line 74 - suggestion: Use Title Case for headings
  • Line 82 - error: Avoid contractions. Use 'do not' instead of 'don't'.
  • Line 101 - suggestion: Spell out 'EULA' on first use
  • Line 102 - warning: Use first person (such as 'I') sparingly.
  • Line 102 - suggestion: Spell out 'AGREE' on first use
  • Line 134 - warning: Use first person (such as ' I') sparingly.
  • Line 138 - error: Don't add '(s)' to a singular noun. Use plural instead.
  • Line 140 - suggestion: Don't use language (such as 'disabled') that defines people by their disability.
  • Line 161 - suggestion: Avoid using first-person plural (we, us, our)
  • Line 192 - error: Use 'hostname' instead of 'host name'
  • Line 204 - suggestion: Use 'login' instead of 'Log In'
  • Line 204 - error: Use 'login' instead of 'Log In'

🔧 To fix: Review the issues above and update your documentation accordingly.

@micjohnson777 micjohnson777 merged commit 52b7296 into master Dec 3, 2025
5 checks passed
@micjohnson777 micjohnson777 deleted the PD-2424-move-ntp-servers-settings branch December 3, 2025 14:34
@bugclerk
Copy link
Contributor

bugclerk commented Dec 3, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants