-
Notifications
You must be signed in to change notification settings - Fork 214
PD-2433 / 26.04 / Pd 2433 update 2 fa content for behavioral changes (by DjP-iX) #4338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
You should reset it
…4330) * Update ManageGlobal2FASCALE.md * Update AdvancedSettingsScreen.md * Update 2FAScreenSCALE.md * Update 2FAScreenEnabled.png * Update SetUpTwoFactorAuthenticationScreen.png * Update 2FAScreenSCALE.md * Delete 2FAQRCodeDialog.png * Delete 2FAScreenDisabled.png * Create Clear2FADialog.png * Create Unset2FASecret.png * Update UserTwoFactorAuthenticationActionsScreen.png * Update UsersScreen.md * Update ManageGlobal2FASCALE.md * Update ManageUsers.md * Update ManageGlobal2FASCALE.md * Update 2FAScreenSCALE.md * grammar fixes --------- Co-authored-by: linzibelle <[email protected]> Co-authored-by: linzi-ix <[email protected]> (cherry picked from commit 90958fb)
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 178 issues found in changed files - 25 errors, 1 warnings, 152 suggestions Changed files with issues: content/SCALE/SCALEUIReference/SystemSettings/AdvancedSettingsScreen.md (76 issues)
content/SCALE/SCALETutorials/SystemSettings/Advanced/ManageGlobal2FASCALE.md (43 issues)
content/SCALE/SCALEUIReference/Credentials/UsersScreen.md (35 issues)
content/SCALE/SCALETutorials/Credentials/ManageUsers.md (19 issues)
content/SCALE/SCALEUIReference/TopToolbar/Settings/2FAScreenSCALE.md (5 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 177 issues found in changed files - 25 errors, 1 warnings, 151 suggestions Changed files with issues: content/SCALE/SCALEUIReference/SystemSettings/AdvancedSettingsScreen.md (75 issues)
content/SCALE/SCALETutorials/SystemSettings/Advanced/ManageGlobal2FASCALE.md (43 issues)
content/SCALE/SCALEUIReference/Credentials/UsersScreen.md (35 issues)
content/SCALE/SCALETutorials/Credentials/ManageUsers.md (19 issues)
content/SCALE/SCALEUIReference/TopToolbar/Settings/2FAScreenSCALE.md (5 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
Changed "Check" to "Select" on line 102 for consistency with our style guide.
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 177 issues found in changed files - 25 errors, 1 warnings, 151 suggestions Changed files with issues: content/SCALE/SCALEUIReference/SystemSettings/AdvancedSettingsScreen.md (75 issues)
content/SCALE/SCALETutorials/SystemSettings/Advanced/ManageGlobal2FASCALE.md (43 issues)
content/SCALE/SCALEUIReference/Credentials/UsersScreen.md (35 issues)
content/SCALE/SCALETutorials/Credentials/ManageUsers.md (19 issues)
content/SCALE/SCALEUIReference/TopToolbar/Settings/2FAScreenSCALE.md (5 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
Changed incorrect use of bold emphasis in lines 136 and 137
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 177 issues found in changed files - 25 errors, 1 warnings, 151 suggestions Changed files with issues: content/SCALE/SCALEUIReference/SystemSettings/AdvancedSettingsScreen.md (75 issues)
content/SCALE/SCALETutorials/SystemSettings/Advanced/ManageGlobal2FASCALE.md (43 issues)
content/SCALE/SCALEUIReference/Credentials/UsersScreen.md (35 issues)
content/SCALE/SCALETutorials/Credentials/ManageUsers.md (19 issues)
content/SCALE/SCALEUIReference/TopToolbar/Settings/2FAScreenSCALE.md (5 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
micjohnson777
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion. I made a few style-related changes (commits for consistency with our style guilde.
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 177 issues found in changed files - 25 errors, 1 warnings, 151 suggestions Changed files with issues: content/SCALE/SCALEUIReference/SystemSettings/AdvancedSettingsScreen.md (75 issues)
content/SCALE/SCALETutorials/SystemSettings/Advanced/ManageGlobal2FASCALE.md (43 issues)
content/SCALE/SCALEUIReference/Credentials/UsersScreen.md (35 issues)
content/SCALE/SCALETutorials/Credentials/ManageUsers.md (19 issues)
content/SCALE/SCALEUIReference/TopToolbar/Settings/2FAScreenSCALE.md (5 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
Vale Style Guide Issues (Previous - Click to expand)Vale Style Guide Issues📊 Summary: 176 issues found in changed files - 25 errors, 1 warnings, 150 suggestions Changed files with issues: content/SCALE/SCALEUIReference/SystemSettings/AdvancedSettingsScreen.md (75 issues)
content/SCALE/SCALETutorials/SystemSettings/Advanced/ManageGlobal2FASCALE.md (43 issues)
content/SCALE/SCALEUIReference/Credentials/UsersScreen.md (34 issues)
content/SCALE/SCALETutorials/Credentials/ManageUsers.md (19 issues)
content/SCALE/SCALEUIReference/TopToolbar/Settings/2FAScreenSCALE.md (5 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
Vale Style Guide Issues📊 Summary: 176 issues found in changed files - 25 errors, 1 warnings, 150 suggestions Changed files with issues: content/SCALE/SCALEUIReference/SystemSettings/AdvancedSettingsScreen.md (75 issues)
content/SCALE/SCALETutorials/SystemSettings/Advanced/ManageGlobal2FASCALE.md (43 issues)
content/SCALE/SCALEUIReference/Credentials/UsersScreen.md (34 issues)
content/SCALE/SCALETutorials/Credentials/ManageUsers.md (19 issues)
content/SCALE/SCALEUIReference/TopToolbar/Settings/2FAScreenSCALE.md (5 issues)
🔧 To fix: Review the issues above and update your documentation accordingly. |
Automatic cherry-pick failed. Please resolve conflicts by running:
If the original PR was merged via a squash, you can just cherry-pick the squashed commit:
Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.
Original PR: #4330
Jira URL: https://ixsystems.atlassian.net/browse/PD-2433