[TRUNK-14370] Do not error on forbidden/unauthorized #443
+114
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes our exit logic to not use error reporting on forbidden/unauthorized errors. While I was there, added a nudge to check your token.
|
Merging to
|
gnalh
reviewed
Feb 27, 2025
cli/src/main.rs
Outdated
| if status == StatusCode::UNAUTHORIZED || status == StatusCode::FORBIDDEN { | ||
| tracing::warn!("Unauthorized to access trunk, are you sure your token is correct? {:?}", error); | ||
| guard.flush(None); | ||
| std::process::exit(exitcode::OK); |
There was a problem hiding this comment.
This might be a footgun when enabling trunk. If we exit success even though it's misconfigured you'll see the CI job succeed and assume all is well.
There was a problem hiding this comment.
Fair; I'll switch it to use the software exit code.
…ry-issues-on-user-config-401403-status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes our exit logic to not use error reporting on forbidden/unauthorized errors. While I was there, added a nudge to check your token.