Replace seahash with rapidhash #1006
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Maintainer of rapidhash here, and I saw that you were using seahash in trunk.
I believe rapidhash comprehensively beats seahash in quality and speed on all platforms, especially for long string/byte hashing. It's fully portable and doesn't rely on any hardware acceleration.
I couldn't find any benchmarks in the repo, but hopefully this improves project build times for users?
Very happy to answer any questions. Cheers!