Fix CVE-2020-35766#260
Open
liberodark wants to merge 1 commit into
Open
Conversation
|
Proposal for a fix of issue #148 (CVE-2022-48521) is already filed as PR #189 by @glts, the reporter of the issue. Also, it seems those two fixes are not logically related. |
Author
|
Hi, @futatuki Good to know. Best Regards |
|
I could confirm that the PR is amended. (Although I am only one of watchers who don't have any authority, but) the logic to avoid overwriting an existing file and the place of the test key looks good to me. If I would add a comment, there are alternative few ideas where and how the test key is placed, in the issue comment for #113 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Fix #113
Best Regards