Fix DKIM_STAT_KEYFAIL error handling on mlfi_eoh() and mlfi_eom() (fix of the issue #176)#262
Open
futatuki wants to merge 6 commits into
Open
Conversation
* opendkim/opendkim.c (mlfi_eom): ditto.
* opendkim/opendkim.c (dkimf_libstatus): Use prepared status string for DKIMF_STATUS_KEYFAIL and DKIMF_STATUS_NOKEY
…script in mlfi_eoh() * opendkim.c (mlfi_eoh): ditto.
Even On-DNSError is set to accept or tempfail, other conditions checked in mlfi_eom may want to reject or discard the message, so the final judgement should be phostponed to mlfi_eom().
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
May 10, 2026
…ndle_keyfail Fix DKIM_STAT_KEYFAIL error handling on mlfi_eoh() and mlfi_eom() (fix of the issue trusteddomainproject#176)
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sane DKIM_STAT_KEYFAIL error handling after signature verification in libopendkim. Please see each commit for detail.