Implement Promise All Settled #872
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komyg
force-pushed
the
feature/promise.all_settled
branch
from
6271720 to
16237ab
Compare
aapoalas
reviewed
Oct 13, 2025
komyg
force-pushed
the
feature/promise.all_settled
branch
from
a68dc67 to
fae782c
Compare
aapoalas
requested changes
Oct 15, 2025
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Show resolved
Hide resolved
|
|
||
| let data = promise_all.get_mut(agent); | ||
|
|
||
| // i. Set remainingElementsCount.[[Value]] to remainingElementsCount.[[Value]] - 1. |
There was a problem hiding this comment.
suggestion: I think we can probably factor out this part and make it a method of the PromiseGroupRecord: take &mut self, reduce remaining_elements_count by 1, and return (Array, Option<Promise>) with the Promise only getting returned if remaining_elements_count == 0. Now the caller can do an assignment into the Array with their value and then resolve the Promise if they received one.
Also note: this way the code doesn't need to first read the result array from the PromiseGroupRecord, then write into that array, and then go back to reading from the PromiseGroupRecord to check the remaining elements count and promise. It can do all of those reads at the same time.
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Outdated
Show resolved
Hide resolved
...m/src/ecmascript/builtins/control_abstraction_objects/promise_objects/promise_constructor.rs
Outdated
Show resolved
Hide resolved
...tins/control_abstraction_objects/promise_objects/promise_abstract_operations/promise_jobs.rs
Outdated
Show resolved
Hide resolved
…ll and PromiseAllSettled
…ection for PromiseAll and PromiseAllSettled, streamlining promise reaction processing.
… fulfillment and rejection handling, improving code clarity and reducing duplication.
komyg
force-pushed
the
feature/promise.all_settled
branch
from
bbf3be7 to
295b9eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.