Allow user provided metadata to override default metadata#62
Open
dbhobbs wants to merge 5 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
==========================================
- Coverage 38.99% 38.78% -0.22%
==========================================
Files 28 28
Lines 2090 2117 +27
==========================================
+ Hits 815 821 +6
- Misses 1275 1296 +21
Continue to review full report at Codecov.
|
ferd
reviewed
Nov 15, 2021
Owner
|
Damn, its been years. I want to merge this functionality but the merge is now hairy. I may have to tweak it to get it working with the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces code that will join duplicate headers into a comma-separated list, if allowed. Otherwise, it will prefer the user supplied value in the case that a default value was provided. It also moves required pseudo-headers into a separate macro which can't be overridden.
Section 4.2 of RFC2616 lays out some rules around multiple message headers.
Allowing duplicate headers like
Content-Typewould change the semantic meaning of the request so, in this PR, only the first header processed is kept. This allows user supplied metadata/headers to override the defaults, but prevents duplicates from being sent.Addresses issue #60.
I've tested this code in my company's backend system and can successfully publish messages to Google Cloud PubSub.