fix(db export): explain unsupported Fly exports#1038
Open
ada-powerful wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #981.
Problem
When
turso db exportis run against a database whose export endpoints are unavailable, the CLI currently bubbles up a raw HTTP error like:For Fly-hosted databases, that does not explain what the user can do next.
Fix
Handle 404 responses in the export path with a specific message explaining that database export is unavailable for that database and pointing users to
turso db shell <database> .dumpas the SQL dump fallback. Other export errors still use the existing response parser.Added a regression test for the
/info404 path so the rawresponse failed with status 404 Not Foundmessage does not come back.Tests
Disclosure
This PR was prepared by an AI agent under direct human review. Happy to adjust the wording if there is a preferred export fallback message.