csv-table-name: reject invalid SQLite identifiers up front#1044
Open
c-tonneslan wants to merge 1 commit into
Open
csv-table-name: reject invalid SQLite identifiers up front#1044c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
.import interpolates the table name directly into a CREATE TABLE statement, so passing something with a dash or a quote produced a cryptic sqlite syntax error that the user had to decode. Validate the name as a conventional unquoted SQLite identifier (letter or underscore, then letters / digits / underscores) before invoking sqlite3 so the message is actionable. Closes the validation half of tursodatabase#810. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the validation half of #810 (the hex-stderr half is in #1042).
`.import` interpolates the table name directly into a `CREATE TABLE` statement, so passing a name with a dash or a quote produced a cryptic sqlite syntax error that the user had to decode. Validate the name as a conventional unquoted SQLite identifier (letter or underscore, then letters / digits / underscores) before invoking sqlite3 so the user gets an actionable error instead.