Conversation
- Replace the breakpoint infix pattern (e.g., `.d-md-none`, `.col-lg-6`) with a prefix pattern using an escaped colon (e.g., `.md\:d-none`, `.lg\:col-6`), - Rename `breakpoint-infix()` to `breakpoint-prefix()` and add `css-escape-ident()` for leading-digit breakpoints like `2xl` - Update `generate-utility()`, grid, and all component/helper loops - Update containers, navbar, offcanvas, tables, list-group, stepper, dialog, sticky, and stacks responsive classes - Update SCSS and JS tests - Update all docs Made-with: Cursor
|
This change is amazing, especially since using breakpoints with utility classes that use semantic values (e.g: |
|
Not sure if this is possible, but any chance of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credit due where credit is due—Tailwind's prefix syntax is better. This migrates us to use it all over the project. One thing I've realized is our responsive utilities having an infix is confusing for where the infix appears and what not. Infix also being buried within the class is annoying for parsing classes IMO.
.d-md-none,.col-lg-6) with a prefix pattern using an escaped colon (e.g.,.md\:d-none,.lg\:col-6),breakpoint-infix()tobreakpoint-prefix()and addcss-escape-ident()for leading-digit breakpoints like2xlgenerate-utility(), grid, and all component/helper loops