Remove stale .form-select selectors from input group styles - #42928
Open
julien-deramond wants to merge 1 commit into
Open
julien-deramond wants to merge 1 commit into
julien-deramond wants to merge 1 commit into
Conversation
.form-select was consolidated into .form-control on <select> elements, but these two selectors in the input group border-radius rules still targeted the old class. They no longer matched anything. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes two leftover
.form-selectselectors inscss/forms/_input-group.scssthat were used for the border-radius rules on floating input groups. Since.form-selectwas consolidated into.form-controlfor<select>elements, these selectors no longer matched anything and were just dead weight.Motivation & Context
While checking the codebase for remaining
.form-selectusage after its consolidation into.form-control, I found these two selectors were never cleaned up. They don't affect rendering today (the.form-controlselector next to them already covers the same elements), but leaving a class name around that no longer exists is confusing for anyone reading or maintaining this file.Type of changes
Checklist
npm run lint)Live previews
Related issues
None. Found during a routine check for lingering
.form-selectreferences.🤖 Generated with Claude Code