feat(server): workspace opt-out of root-domain directory listing by FelixMalfait · Pull Request #22423 · twentyhq/twenty

FelixMalfait · 2026-07-01T20:41:32Z

What

Lets a workspace opt out of being surfaced in the multi-workspace root-domain (app.twenty.com) picker via email-domain discovery.

Adds isDirectoryListingEnabled (default true) on the workspace. When false, the workspace is filtered out of the approved-access-domain branch of findAvailableWorkspacesByEmail, so a user whose email domain matches an approved access domain no longer sees the workspace in the sign-up picker.

Scope of the opt-out (deliberately narrow)

The filter is applied only to the approved-access-domain discovery source:

Members (availableWorkspacesForSignIn) — never filtered; they keep access.
Explicit invitations — never filtered; the intent is one-to-one.
Approved-access-domain discovery — the only "listing" source, gated by the flag.

A hidden workspace stays fully reachable by members and invited users via the direct workspace subdomain; it just isn't advertised in the global picker.

Open question for review: do we also want a stronger mode that hides the workspace from the root-domain picker even for existing members (forcing them to use the subdomain directly)? That would additionally filter the member/invitation sources and is a larger behavior change — not included here.

Changes

Backend

workspace.entity.ts — new isDirectoryListingEnabled column (@Field, default true).
user-workspace.service.ts — filter the approved-access-domain branch on the flag.
update-workspace-input.ts — expose the field on updateWorkspace.
workspace.service.ts — PermissionFlagType.SECURITY (same as the other discovery/security toggles).
Fast instance command adding the column (default true, so no existing workspace is hidden).

Frontend

Settings > Security: a "List in workspace directory" toggle (shown only in multi-workspace mode) that flips the flag via updateWorkspace, mirroring the existing isInternalMessagesImportEnabled toggle.
Threaded the field through the current-user fragment, CurrentWorkspace type, and mock data.
Regenerated the metadata + client-sdk GraphQL types (generated-metadata, twenty-client-sdk/.../generated) — generated against a server booted from this branch.

Verification

tsgo typecheck: 0 errors. oxlint: 0/0. oxfmt: clean.
Codegen diff verified to contain only the new field (no unrelated drift).
Tests not run locally; CI covers unit/integration + the codegen/migration freshness checks.

Adds an isDirectoryListingEnabled flag (default true) on the workspace. When disabled, the workspace is excluded from approved-access-domain discovery in findAvailableWorkspacesByEmail, so it no longer appears in the multi-workspace root-domain picker for users who match its email domain. Existing members and explicitly invited users are unaffected. The flag is a SECURITY-permissioned field on updateWorkspace and is added via a fast instance command.

twenty-ci-bot-public · 2026-07-01T20:42:00Z

🚀 Preview Environment Ready!

Your preview environment is available at: https://identify-supervisors-disturbed-scope.trycloudflare.com

This environment will automatically shut down after 5 hours.

cubic-dev-ai

No issues found across 6 files

_{Re-trigger cubic}

FelixMalfait · 2026-07-01T21:01:11Z

  @Column({ default: true })
  isPublicInviteLinkEnabled: boolean;

+  // When false, the workspace is hidden from approved-access-domain discovery


Remove comment

twenty-ci-bot-public · 2026-07-01T21:05:56Z

🔍 Automated Pre-Review

✅ No issues detected - This PR is ready for human review.

View details

Automated pre-review — human approval still required.

…ypes Adds a 'List in workspace directory' toggle under Settings > Security (shown only in multi-workspace mode) that flips isDirectoryListingEnabled via updateWorkspace, and threads the field through the current-user fragment, CurrentWorkspace type and mocks. Regenerates the metadata and client-sdk GraphQL types for the new field.

cubic-dev-ai

1 issue found across 10 files (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/twenty-front/src/modules/settings/security/components/SettingsSecuritySettings.tsx">

<violation number="1" location="packages/twenty-front/src/modules/settings/security/components/SettingsSecuritySettings.tsx:157">
P2: If the mutation fails (network error, validation, etc.), the toggle will stay in the changed position despite the server rejecting it — the local state is optimistically updated but never rolled back on error. This is the same pattern as handleSyncInternalEmailsChange in this file, so it's consistent, but adding a rollback in the .catch() would make the UI more reliable and avoid confusing the user.</violation>
</file>

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

The new isDirectoryListingEnabled column on WorkspaceEntity is a cached field, so it is required on FlatWorkspace. Add the missing mapping to fix the tsgo typecheck error. Claude-Session: https://claude.ai/code/session_01GwCx8XsGh7g4yx6C9ctbYx

twenty-ci-bot-public · 2026-07-02T04:36:23Z

🔍 Visual Regression Review — `twenty-front`

✅ 3 visual change(s) reviewed — all explained by this PR.

Changed: 4 · Added: 0 · Removed: 0 · Unchanged: 698

3 item(s) to double-check (uncertain / low confidence)

	Story	Verdict	Confidence	Explained by
🟡	`modules-settings-playground-graphqlplayground--default`	uncertain	62%	—
🟡	`modules-settings-accounts-blocklist-settingsaccountsblocklistinput--default`	uncertain	65%	—
🟡	`ui-feedback-snackbarmanager-snackbar--default`	uncertain	70%	—

Changed stories

Story	Diff %
modules-settings-playground-graphqlplayground--default	3%
modules-settings-accounts-blocklist-settingsaccountsblocklistinput--default	1%
ui-feedback-snackbarmanager-snackbar--default	0%
modules-objectrecord-recordcalendar-month--default	0%

View run details · advisory mode

…tation The Settings > Security directory-listing toggle updates the field via updateWorkspace but the mutation did not select it back, so the Apollo cache kept a stale value (unlike its mirror isInternalMessagesImportEnabled). Select the field in the mutation and regenerate the metadata GraphQL types. Claude-Session: https://claude.ai/code/session_01GwCx8XsGh7g4yx6C9ctbYx

Address review feedback. Claude-Session: https://claude.ai/code/session_01GwCx8XsGh7g4yx6C9ctbYx

FelixMalfait · 2026-07-02T06:54:46Z

+              <SettingsOptionCardContentToggle
+                Icon={IconList}
+                title={t`List in workspace directory`}
+                description={t`Let people whose email domain matches an approved access domain find this workspace on the sign-in screen. Members and invited users are unaffected.`}


Is this linked to approved domain?
I feel like this explanation is wrong let's be more explicit, says that's it's about app.Twenty.com (or replace with whatever url it is). Move to the authentication section. Make the test very clear by also maybe mentioning current workspace url (not sure if a good idea because it might be too long)

Address review feedback: relocate the 'List in workspace directory' toggle from a standalone Discovery section into the Authentication section (grouped with Invite by Link), and rewrite the description to be explicit about the root multi-workspace sign-in domain and its link to approved access domains. The domain is read from client config so it is correct for self-hosted instances. Optimistically updates with rollback on error, matching the sibling auth toggles. Claude-Session: https://claude.ai/code/session_01GwCx8XsGh7g4yx6C9ctbYx

cubic-dev-ai

1 issue found across 2 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

Address review feedback: read the latest currentWorkspace value in both the optimistic update and the error rollback via Jotai's functional updater, so a concurrent workspace-state change during an in-flight request isn't overwritten by a stale closure snapshot. Claude-Session: https://claude.ai/code/session_01GwCx8XsGh7g4yx6C9ctbYx

cubic-dev-ai

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/twenty-front/src/modules/settings/security/components/SettingsSecurityAuthProvidersOptionsList.tsx">

<violation number="1" location="packages/twenty-front/src/modules/settings/security/components/SettingsSecurityAuthProvidersOptionsList.tsx:143">
P2: The optimistic rollback in `handleDirectoryListingChange` unconditionally applies `!value` for any failed request. Because `value` is captured in the closure, if a user toggles rapidly and two requests overlap, the later rollback can overwrite the correct state restored by the earlier one. The `Toggle` component has no debounce and the handler never disables it during a mutation, so this overlap is possible.

A simple guard is to only rollback when the current atom value still matches the optimistic value that was applied (`isDirectoryListingEnabled === value`). This prevents a stale-failure handler from corrupting state that has since been updated by another toggle.</violation>
</file>

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

cubic-dev-ai · 2026-07-02T07:14:42Z

+      return;
+    }
+
+    setCurrentWorkspace((currentWorkspaceValue) =>


P2: The optimistic rollback in handleDirectoryListingChange unconditionally applies !value for any failed request. Because value is captured in the closure, if a user toggles rapidly and two requests overlap, the later rollback can overwrite the correct state restored by the earlier one. The Toggle component has no debounce and the handler never disables it during a mutation, so this overlap is possible.

A simple guard is to only rollback when the current atom value still matches the optimistic value that was applied (isDirectoryListingEnabled === value). This prevents a stale-failure handler from corrupting state that has since been updated by another toggle.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/modules/settings/security/components/SettingsSecurityAuthProvidersOptionsList.tsx, line 143: <comment>The optimistic rollback in `handleDirectoryListingChange` unconditionally applies `!value` for any failed request. Because `value` is captured in the closure, if a user toggles rapidly and two requests overlap, the later rollback can overwrite the correct state restored by the earlier one. The `Toggle` component has no debounce and the handler never disables it during a mutation, so this overlap is possible. A simple guard is to only rollback when the current atom value still matches the optimistic value that was applied (`isDirectoryListingEnabled === value`). This prevents a stale-failure handler from corrupting state that has since been updated by another toggle.</comment> <file context> @@ -140,10 +140,11 @@ export const SettingsSecurityAuthProvidersOptionsList = () => { - ...currentWorkspace, - isDirectoryListingEnabled: value, - }); + setCurrentWorkspace((currentWorkspaceValue) => + currentWorkspaceValue + ? { ...currentWorkspaceValue, isDirectoryListingEnabled: value } </file context>

FelixMalfait · 2026-07-02T08:01:38Z

Open question for review: do we also want a stronger mode that hides the workspace from the root-domain picker even for existing members (forcing them to use the subdomain directly)? That would additionally filter the member/invitation sources and is a larger behavior change — not included here.

--> I think we should revisit this and cover both. Not sure if it should be a dropdown, two toggles, etc? UX need to be clear for user. @claude please look at this in depth and describe all options (with text) + make recommandations

twenty-eng-sync Bot added the -PR: draft label Jul 1, 2026

twenty-eng-sync Bot assigned FelixMalfait Jul 1, 2026

cubic-dev-ai Bot reviewed Jul 1, 2026

View reviewed changes

FelixMalfait commented Jul 1, 2026

View reviewed changes

Merge branch 'main' into feat/workspace-directory-listing-optout

a0325d1

cubic-dev-ai Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread packages/twenty-front/src/modules/settings/security/components/SettingsSecuritySettings.tsx Outdated

FelixMalfait added 2 commits July 2, 2026 05:34

chore(server): remove comment on isDirectoryListingEnabled column

cc742f3

Address review feedback. Claude-Session: https://claude.ai/code/session_01GwCx8XsGh7g4yx6C9ctbYx

FelixMalfait commented Jul 2, 2026

View reviewed changes

cubic-dev-ai Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread ...-front/src/modules/settings/security/components/SettingsSecurityAuthProvidersOptionsList.tsx Outdated

cubic-dev-ai Bot reviewed Jul 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(server): workspace opt-out of root-domain directory listing#22423

feat(server): workspace opt-out of root-domain directory listing#22423
FelixMalfait wants to merge 8 commits into
mainfrom
feat/workspace-directory-listing-optout

FelixMalfait commented Jul 1, 2026 •

edited

Loading

Uh oh!

twenty-ci-bot-public Bot commented Jul 1, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

FelixMalfait Jul 1, 2026

Uh oh!

twenty-ci-bot-public Bot commented Jul 1, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

twenty-ci-bot-public Bot commented Jul 2, 2026 •

edited

Loading

Uh oh!

FelixMalfait Jul 2, 2026

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot Jul 2, 2026

Uh oh!

FelixMalfait commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

FelixMalfait commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Scope of the opt-out (deliberately narrow)

Changes

Verification

Uh oh!

twenty-ci-bot-public Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

FelixMalfait Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

twenty-ci-bot-public Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Automated Pre-Review

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

twenty-ci-bot-public Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Visual Regression Review — twenty-front

Uh oh!

FelixMalfait Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

FelixMalfait commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

FelixMalfait commented Jul 1, 2026 •

edited

Loading

twenty-ci-bot-public Bot commented Jul 1, 2026 •

edited

Loading

twenty-ci-bot-public Bot commented Jul 1, 2026 •

edited

Loading

twenty-ci-bot-public Bot commented Jul 2, 2026 •

edited

Loading

🔍 Visual Regression Review — `twenty-front`

cubic-dev-ai Bot left a comment •

edited

Loading