Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated assertEquals() with assertEqual() in tests #95

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Nov 4, 2023

Replace the calls to the deprecated assertEquals() method in tests with the modern assertEqual(). This fixes compatibility with Python 3.12 where the deprecated aliases were removed.

Replace the calls to the deprecated `assertEquals()` method in tests
with the modern `assertEqual()`.  This fixes compatibility with
Python 3.12 where the deprecated aliases were removed.
@glyph
Copy link
Member

glyph commented Nov 4, 2023

Ugh, looks like we need some real updates to CI

@glyph
Copy link
Member

glyph commented Nov 6, 2023

Test matrix is a little wonky for some reason, but at least we have 3.12 tested and passing, so I'm going to call this good.

@glyph glyph merged commit b74680b into twisted:trunk Nov 6, 2023
3 checks passed
@mgorny
Copy link
Contributor Author

mgorny commented Nov 6, 2023

Thanks!

@mgorny mgorny deleted the py312 branch November 6, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants