Skip to content

Conversation

@jeffascript
Copy link

fix for #136

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2022

CLA assistant check
All committers have signed the CLA.

<div id="header-text">
{{ block "header" . }}
{{ with .Title }}<h2 class="large-title">{{ . }}</h2>{{ end }}
{{ with .Params.subtitle }}<h1 class="subtitle">{{ . }}</h1>{{ end }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{ with .Title }}

{{ . }}

{{ end }}
{{ with .Params.subtitle }}

{{ . }}

{{ end }}

I guess Title should make use of h1 rather than subtitle

Copy link

@harshsingh32 harshsingh32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants