Update transaction and query options specifications for GRPC and HTTP #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
|
This PR will be merged after the referenced changes are released. |
farost
commented
Apr 17, 2025
| @@ -4,7 +4,9 @@ The TypeDB HTTP endpoint can be used to perform database management, user manage | |||
|
|
|||
| == Server configuration | |||
|
|
|||
| TypeDB server by runs both a gRPC (standard for most of the client applications) and an HTTP endpoint by default. Both endpoints have common authentication and xref:{page-version}@manual::configure/encryption.adoc[encryption settings]. Additionally, it is possible to disable the HTTP endpoint and change its default port. | |||
There was a problem hiding this comment.
There are many formatting updates. I will highlight what I actually changed
farost
commented
Apr 17, 2025
| [NOTE] | ||
| ==== | ||
| This behaviour will be changed in the next stable version of TypeDB: | ||
| - Read queries will return `206 Partial Content` with all the answers processed; |
There was a problem hiding this comment.
This is what I've changed
flyingsilverfin
approved these changes
Apr 17, 2025
farost
changed the title
farost
commented
Apr 25, 2025
| @@ -171,3 +171,67 @@ HTTP:: | |||
| Refer to xref:{page-version}@drivers::http/index.adoc#_run_queries[Running queries through HTTP endpoint]. | |||
| -- | |||
| ==== | |||
|
|
|||
| [#_transaction_options] | |||
There was a problem hiding this comment.
Do I need to put a note that it's available since 3.2.0 or smth?
There was a problem hiding this comment.
Not major enough i think
flyingsilverfin
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add transaction and query options specification for GRPC and HTTP.
Implementation
Update HTTP's answerCountLimit behavior for write queries to match the updated behavior in typedb/typedb#7437.
Add a new section in the server transactions manual describing transaction and query options.
Save descriptions and default values of the options in a separate
resourcesfolder to: