feat!!: add v30 changes #107
Conversation
tharropoulos
force-pushed
the
v30
branch
2 times, most recently
from
3f69914 to
733dab4
Compare
| /** | ||
| * AnalyticsEvents constructor. | ||
| * | ||
| * @param ApiCall $apiCall |
There was a problem hiding this comment.
Any reason these definitions are removed?
There was a problem hiding this comment.
added them back 26e6f80. The entire file was re-written from scratch, but the diff algorithm shows it as modified
src/AnalyticsRules.php
Outdated
| public function offsetSet($offset, $value): void | ||
| { | ||
| $this->analyticsRules[$offset] = $value; | ||
| // Not implemented for read-only access |
There was a problem hiding this comment.
Why not? It would be nice for users to be able to access it via array notation for read-only access right?
There was a problem hiding this comment.
This goes back to a really old issue on Laravel Scout, where we only checked for memory instances of collections and as a result, queue workers tried to access collections that didn't exist. Added it back to keep backwards compatibility though
|
Maybe you can consider making an RC tag of this so its a bit smoother to test it together with typesense v30? |
3 participants
Change Summary
Add the v30 changes to the client:
PR Checklist