Skip to content

Conversation

@Enivex
Copy link
Collaborator

@Enivex Enivex commented Jun 14, 2025

There are also some additional dingbats, but I avoided adding them both because naming is hard, they double as emojis, and it's not entirely clear whether they belong under bullet or not.

Closes #88

@Enivex Enivex added waiting on reviews Breaking and non-breaking changes need respectively 3 and 2 reviews blocked This is blocked by something labels Jun 14, 2025
@MDLC01
Copy link
Collaborator

MDLC01 commented Jun 14, 2025

U+2022 • BULLET (sym.bullet) has the Unicode informative alias "black small circle", but is not present in Typst as a variant of sym.circle. U+2219 ∙ BULLET OPERATOR (sym.bullet.op in this PR) has no Unicode informative alias, but is already present as sym.circle.filled.small.

Do you know what the point of bullet.hole is?

@Enivex
Copy link
Collaborator Author

Enivex commented Jun 14, 2025

U+2022 • BULLET (sym.bullet) has the Unicode informative alias "black small circle", but is not present in Typst as a variant of sym.circle. U+2219 ∙ BULLET OPERATOR (sym.bullet.op in this PR) has no Unicode informative alias, but is already present as sym.circle.filled.small.

We need to do an overhaul of geometric shapes at one point, but that's a much bigger project

Do you know what the point of bullet.hole is?

I believe it's just another alternative bullet for use in lists. Font support is pretty lacking though.

Edit: This is what it looks like in Noto Sans Symbols 2
image

It's official name is "inverse bullet"

Copy link
Collaborator

@MDLC01 MDLC01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing as it seems to be used as list markers in some documents, let's keep bullet.hole.

@Enivex Enivex removed the blocked This is blocked by something label Jul 1, 2025
Copy link
Collaborator

@T0mstone T0mstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly to circle.stroked.tiny with compose.o, we'll probably want to deprecate circle.filled.small in favor of bullet.op too. (Both of these codepoints are in the Mathematical Operators block)

Edit to clarify: I don't mean that such a deprecation has to happen in this PR.

@Enivex
Copy link
Collaborator Author

Enivex commented Jul 1, 2025

Similarly to circle.stroked.tiny with compose.o, we'll probably want to deprecate circle.filled.small in favor of bullet.op too. (Both of these codepoints are in the Mathematical Operators block)

Edit to clarify: I don't mean that such a deprecation has to happen in this PR.

We need a more systematic and consistent naming scheme for the geometric shapes at least.

There's no real hard distinction between mathematical operators and geometric shapes. Some are used for both.

@Enivex Enivex merged commit 8c2ae20 into typst:main Jul 1, 2025
1 check passed
@Enivex Enivex deleted the bullets branch July 3, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting on reviews Breaking and non-breaking changes need respectively 3 and 2 reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triangular bullet

3 participants