Add a reset API#78
Open
LaurenzV wants to merge 1 commit into
Open
Conversation
Member
|
Maybe the settings could be changed arbitrarily, then the combinations of constructors could be reduced and instead a builder method and a setter (and even a getter?) could be exposed. |
Member
|
I'm fine with this, but would try avoid it taking CI is failing though due to formatting. |
Member
|
A separate bulider type could be circumvented if we allow changing the But yeah, that doesn't need to happen in this PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to reset chunks, making it possible to reuse the inner allocations. While I don't have a specific need for this now, I think it could come in handy in the future.
I'm not sure if the
resetmethod should takeSettingsas well so that they can be changed if desired. Or maybe areset_with_settingsmethod?