#19 Use clang-format#255
Conversation
* Check clang-format with reviewdog
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
* Added configuration file and exlusions for clang-format
* Better exclusions. Fixed some rules
* Applied formatting
* Tabs to spaces for generated code * Stop using digit separator. It's a c++14 feature that clang-format doesn't handle correctly when in C++11 mode * Split LrpcTypes into LrpcBaseTypes.hpp and byte-specific code in LrpcBaseTypes.hpp * Removed dependency on code-generation package. Using custom code in src/codegen/cppfile/cpp_file.py
* Fixed stale imports
* Fix long lines
* Some CppFile updates
* Update files for new code generation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| self._indent = indent | ||
| self._level = 0 | ||
| self._owns_file = writer is None | ||
| self._file: TextIO = Path(filename).open("w") if writer is None else writer # noqa: SIM115 |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
| self._indent = indent | ||
| self._level = 0 | ||
| self._owns_file = writer is None | ||
| self._file: TextIO = Path(filename).open("w") if writer is None else writer # noqa: SIM115 |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
| @@ -0,0 +1 @@ | |||
| from .cpp_file import CppFile as CppFile | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R0801: Similar lines in 2 files
| @@ -0,0 +1 @@ | |||
| from .cpp_file import CppFile as CppFile | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R0801: Similar lines in 2 files
* Some clang-format ignores * Refactor generation of LrpcBaseTypes.hpp and LrpcByteTypes.hpp
* Update linkspector
|
1 participant
❇️ @coderabbitai
Description
Fixes issue #19
@coderabbitai summary
Type