Update wording of resolvers guide #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given ua-parser/uap-rust#29 and ua-parser/uap-rust#31, the wording of the comparison needs to be updated to account for: - The `regex` memory use being much improved. - The `regex` runtime on devices being slightly improved, with the Python interface to `re2` not supporting custom atom lengths. Closes ua-parser#264
Contributor
Author
|
Note: needs to wait for the publication of CPython 3.13.5 before being merged (cf ua-parser/uap-rust#37) |
Contributor
Author
|
It might actually make sense to remove the |
Don't remove the feature, don't remove the resolver, and keep the resolver itself documented, but significantly de-emphasize `re2` by removing it from the README and from examples: users should not be encouraged to use it when they could use `regex`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given ua-parser/uap-rust#29 and ua-parser/uap-rust#31, the wording of the comparison needs to be updated to account for:
regexmemory use being much improved.regexruntime on devices being slightly improved, with the Python interface tore2not supporting custom atom lengths.Closes #264