feat: Add Singularity support and improve code organization #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arity setup scripts for postgres as an alternative to docker containers for cluster environments
…ter setup with conda and singularity)
…ster environments. Moving all scripts to the ./scripts/ folder and deletion of ./settings/scripts/ folder
…ets the seed for the rest of the execution and avoids a seed reset to the default value. The value was previously always set to 0 and no other seeds were allowed by the code. Finally, torch.use_deterministic_algorithms automatically overwrites torch.backends.cudnn.deterministic and torch.manual_seed already calls internally torch.cuca.manual_seed_all
|
Hi @lorenzo9uerra, thanks for opening this PR! |
|
@lorenzo9uerra I'll need some more time as I also have to merge some of my code and it's gonna be hard to merge given that you applied some code formatting. |
|
I have rerun ruff format on the project, I hope it helps. I don't know why it missed the pre-commit hook before |
|
Thanks, should help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds Singularity container support for cluster deployments, and includes minor fixes and refactoring.
Changes
stats["percent_detected_attacks"]calculation to properly compute the percentage of detected attacks. Moreover, "detected_attacks" is now updated with detected attacks only when a node is correctly classified, while before it was always updated.All changes maintain backward compatibility with existing configurations and workflow.