Repository navigation
docs: fix dead source and Marker API links - #5438
Open
farisbasha wants to merge 1 commit into
Open
farisbasha wants to merge 1 commit into
farisbasha wants to merge 1 commit into
Conversation
The phone-input blog post linked to src/phone-input/phone-input.js on master, which now ends in a 404 (the file is phone-input.tsx on main). The map marker pages linked to the react-map-gl Marker API reference at visgl.github.io/react-map-gl/docs/api-reference/marker, which returns 404. Point them at the Marker docs for react-map-gl v5.2.13, the version the documentation-site examples use.
farisbasha
requested review from
DianaSuvorova,
dyesin,
hualf1995 and
lijim
as code owners
November 17, 2026 22:13
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two kinds of dead links in the documentation site:
pages/blog/phone-input/index.mdxlinks toblob/master/src/phone-input/phone-input.js. That redirects tomainand then returns 404, because the file is nowphone-input.tsx. Updated toblob/main/src/phone-input/phone-input.tsx.fixed-marker.mdx,floating-marker.mdxandfloating-route-marker.mdxlink tohttps://visgl.github.io/react-map-gl/docs/api-reference/marker, which returns 404 (the current site only has per-backendmapbox/markerandmaplibre/markerpages for v8). The examples on these pages importMarkerfromreact-map-gl5.2.13 (the version inpackage.json), so the links now point at the v5.2.13 Marker docs:https://github.com/visgl/react-map-gl/blob/v5.2.13/docs/api-reference/marker.md.Checked every old and new URL with
curl -sI(no redirect following): old ones 404, new ones 200. Docs-only change.Scope
Patch: Bug Fix