Failing test for Java delete_all_statements_after_return#284
Draft
dvmarcilio wants to merge 1 commit intomasterfrom
Draft
Failing test for Java delete_all_statements_after_return#284dvmarcilio wants to merge 1 commit intomasterfrom
delete_all_statements_after_return#284dvmarcilio wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Java
delete_all_statements_after_returnis only working for the 1st statement.From the code below (considering that the
experimentation.isToggleEnabled()call is replaced byfalse):We would expect the following:
Instead, we are getting:
Discussion
This is the query for
delete_all_statements_after_return:( (block ((statement)* @pre) ((return_statement) @r) ((statement)+ @post) ) @b )For the code discussed in the Problem section, this is the match we get using tree-sitter CLI:
So
((statement)+ @post)produces multiple one-line matches (same start/end row).Perhaps the internal replace implementation expects a multi-line match for
@post(as in(block) @b)?Possible Solution
The self-edge solution from #265 would also work here, not requiring any modifications to the rust code.