Split up settings object#1162
Open
cj-young wants to merge 33 commits into
Open
Conversation
The API and `updateUserSettings` are updated here temporarily to accommodate the new structure of user preferences and allow automatic updates. These will be overwritten.
The API call to deauthorize users was commented out because the API class no longer has that method. It hadn't worked anyway, since the route it tries to reach can only update users that call it.
cj-young
force-pushed
the
issue/1161-settings_split
branch
from
f305a0c to
a50f619
Compare
mbusch3
requested changes
Apr 28, 2026
Contributor
mbusch3
left a comment
mbusch3
left a comment
There was a problem hiding this comment.
VERY thorough work. I will continue to review and make further suggestions.
cj-young
force-pushed
the
issue/1161-settings_split
branch
from
1ff0cd0 to
777d306
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to resolve #1161.