fix: preserve verification diagnostics

[altaywtf]

Summary

Address the three unresolved review findings from #8 without weakening authored wiki-page validation.

Changed

• Replay buffered stdout and stderr as one ordered event stream.
• Deduplicate repeated registry and wiki-backfill failures in verify.
• Generate empty daily-log catalogs with sources: [].
• Permit empty sources only for generated sources/ and tags/ catalogs.
• Normalize Windows path separators before classifying generated catalogs.

Review aids

Case	Before	After
Repeated validation failure	The same JSON error could appear twice	Each distinct error appears once
Mixed check output	A later success could print before an earlier failure	Events retain check execution order across stdout and stderr
Empty generated catalog	Self-referenced memory/wiki/index.md	Explicit sources: [], accepted only for generated catalogs

Original review threads:

• Duplicate errors
• Output ordering
• Empty catalog self-reference

Risks

Low. The output change preserves the existing buffered CLI contract while retaining event order. Authored wiki pages still require non-empty sources.

Verification

• pnpm exec vp test run test/cli-commands.test.ts — 17 passed
• pnpm exec vp run verify — 136 passed; format, lint, types, coverage, package build, and packed install smoke passed
• autoreview --mode local — clean after validating and fixing its Windows path finding

Complexity

Output event replay and deduplication are linear in the number of emitted messages and validation errors.

---

Note

Low Risk
CLI output and wiki lint/backfill behavior changes are localized; authored wiki validation is unchanged and covered by new tests.

Overview
doctor and verify now buffer check output as a single ordered stdout/stderr event stream and replay it in execution order, so an earlier failure is not printed after a later success. verify also deduplicates repeated registry and wiki-backfill error lines in JSON and plain stderr.

Wiki catalogs: empty daily-log backfill pages emit sources: [] instead of a self-referential index link. Wiki lint allows empty sources only under generated sources/ and tags/ paths; authored pages still need non-empty sources. Path handling normalizes Windows backslashes before classifying generated catalogs.

docs/convention.md documents the authored vs generated sources rule. CLI tests cover combined output ordering, single-shot registry errors, and scaffold daily-log sources: [] lint-green behavior.

^{Reviewed by Cursor Bugbot for commit da9fc70. Bugbot is set up for automated code reviews on this repo. Configure here.}

---

Summary by cubic

Preserves verification diagnostics by keeping output order and removing duplicate errors, and aligns wiki backfill/lint rules for empty generated catalogs. Also fixes Windows path handling for catalog detection.

• Bug Fixes
  • Replays stdout and stderr as one ordered stream to keep check order.
  • Deduplicates repeated registry and wiki-backfill errors in verify.
  • Allows sources: [] only for generated sources/ and tags/ catalogs; authored pages still require sources.
  • Normalizes Windows path separators before classifying generated catalogs.
  • Updates docs and tests to cover ordering, deduplication, and empty catalog cases.

^{Written for commit da9fc70. Summary will update on new commits.}

[Copilot]

Pull request overview

This PR refines workspace-kit verify/doctor diagnostics so buffered output preserves check execution order across stdout/stderr, while also deduplicating repeated validation failures and tightening wiki-catalog rules to allow sources: [] only for generated catalogs.

Changes:

• Buffer and replay doctor/verify output as an ordered event stream (stdout + stderr), preserving per-check ordering.
• Deduplicate repeated registry and wiki-backfill failure messages in verify output/JSON errors.
• Emit sources: [] for empty generated daily-log catalogs and relax wiki lint to allow empty sources only for generated sources/ and tags/ catalogs (with Windows path separator normalization).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/cli-commands.test.ts	Adds regression coverage for ordered output replay, generated-catalog sources: [], and deduped verify errors.
src/cli.ts	Introduces ordered output events + shared emitter, and dedupes added verify errors to avoid repeats.
src/checks/wikiLint.ts	Normalizes Windows separators consistently and permits empty sources only for generated catalogs.
src/checks/wikiBackfill.ts	Writes empty daily-log catalog sources as sources: [] instead of self-referencing.
docs/convention.md	Updates documentation to reflect authored-vs-generated sources requirements.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cubic-dev-ai]

No issues found across 5 files

_{Re-trigger cubic}