Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menuconfig): allow choice override menuconfig #123

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion menuconfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -1202,7 +1202,26 @@ def _leave_menu():
# Jump to parent menu
parent = _parent_menu(_cur_menu)
_shown = _shown_nodes(parent)
_sel_node_i = _shown.index(_cur_menu)

try:
_sel_node_i = _shown.index(_cur_menu)
except ValueError:
# Since we can have choice overrides sprinkled throughout the tree
# we must handle the case of a overridden choice symbol containing
# a menuconfig.
# Simply taking the parent of the overridden choice symbol will not
# be able to navigate back, thus, not able to figure out the index.
# Insead we have to look in the items for the choice override with
# the prompt to go back to that location.
for node in _cur_menu.item.nodes:
try:
parent = _parent_menu(node)
_shown = _shown_nodes(parent)
_sel_node_i = _shown.index(node)
break
except ValueError:
pass

_cur_menu = parent

# Try to make the menu entry appear on the same row on the screen as it did
Expand Down