-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Block List: Remove bold label from inline editing #20437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block List: Remove bold label from inline editing #20437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the bold font styling from block list inline editing labels to improve the visual appearance and consistency of the UI.
- Removes the
font-weight: 700CSS rule applied to the#nameelement in inline list blocks
|
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
@AndyButland @nielslyngsoe any specific reason label of block list, when inline editing, should be bold, or can we streamline this? :) |
|
Hi @bjarnef, Thanks for your PR to improve the consistency of the bold labelling in the inline editing. It seems low risk and a case of stylistic consistency/preference. You've already tagged some of HQ so if they confirm this is all good, HQ or one of the core collabs will get this merged in. Best wishes Emma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted @bjarnef , thanks!
Prerequisites
If there's an existing issue for this PR then this fixes #20404
Description
Removing bold from block list inline editing to align with when line inline editing and also aligns with block grid labels.
Before
After