Skip to content

Conversation

@bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Oct 9, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #20404

Description

Removing bold from block list inline editing to align with when line inline editing and also aligns with block grid labels.

Before

image

After

image

@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 23:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the bold font styling from block list inline editing labels to improve the visual appearance and consistency of the UI.

  • Removes the font-weight: 700 CSS rule applied to the #name element in inline list blocks

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bjarnef bjarnef changed the title Remove bold label from block list inline editing Block List: Remove bold label from inline editing Oct 9, 2025
@bjarnef
Copy link
Contributor Author

bjarnef commented Oct 13, 2025

@AndyButland @nielslyngsoe any specific reason label of block list, when inline editing, should be bold, or can we streamline this? :)

@emmagarland emmagarland self-assigned this Oct 20, 2025
@emmagarland
Copy link
Contributor

Hi @bjarnef,

Thanks for your PR to improve the consistency of the bold labelling in the inline editing. It seems low risk and a case of stylistic consistency/preference.

You've already tagged some of HQ so if they confirm this is all good, HQ or one of the core collabs will get this merged in.

Best wishes

Emma

Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted @bjarnef , thanks!

@nielslyngsoe nielslyngsoe merged commit 3854b2b into umbraco:main Oct 23, 2025
28 checks passed
@bjarnef bjarnef deleted the bugfix/block-list-inline-label-bold branch October 23, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block label is bold in inline editing mode

3 participants