-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add endpoint descriptions to all Management API controllers #20690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…points Co-authored-by: AndyButland <[email protected]>
Co-authored-by: AndyButland <[email protected]>
|
Good start @copilot but there are a couple of things to improve.
|
Co-authored-by: AndyButland <[email protected]>
Fixed in commit 9e0739a:
|
|
@copilot can you extend this now for all controllers found under the |
Working on extending descriptions to all controllers. Found 336 files with 350 endpoints missing descriptions. Creating automated solution to systematically add |
Co-authored-by: AndyButland <[email protected]>
Co-authored-by: AndyButland <[email protected]>
|
@copilot - a few more requests please:
|
…ments Co-authored-by: AndyButland <[email protected]>
Fixed in commit 539a4bb:
|
|
…butes Co-authored-by: AndyButland <[email protected]>
Fixed in commit 6658e2a:
|
|
@copilot - please revert the last commit |
…te attributes" Co-authored-by: AndyButland <[email protected]>
|
Co-authored-by: AndyButland <[email protected]>
Fixed in commit 37dbdfc:
|
|
Please review a few things:
Don't make any changes from this prompt, I'd just like the information. |
Here are the answers to your three questions: 1. Controllers missing EndpointSummary and EndpointDescription: Yes, there are 7 public HTTP methods missing both attributes:
Out of 439 total public HTTP methods in the Management API controllers, 432 have both attributes (98.4% coverage). 2. Duplicate attributes: No, there are no duplicate attributes on any methods in the modified controllers. All duplicates have been removed. 3. Other changes beyond EndpointSummary/EndpointDescription: No, there are no other substantive changes. The PR only includes:
All changes are limited to adding the requested endpoint documentation attributes and the necessary using statements to support them. |
|
@copilot - please add the missing
|
Co-authored-by: AndyButland <[email protected]>
Added in commit f0547a9. All 7 missing endpoints now have EndpointSummary and EndpointDescription attributes following the original style guide:
All 439 Management API endpoints now have complete documentation (100% coverage). |
|
@copilot - some of the descriptions added have redundant or incorrect words or phrases. For example, "Gets a paginated collection of all user groups with support for skip and take pagination." repeats the word "pagination". It also mentions "all user groups", but if it's paginated, it isn't necessary all of them. In this example a better description would be: "Gets a paginated collection of user groups." Please can look across all 439 management API endpoints and suggest updates for cases like these? |
I've analyzed all 439 endpoints and identified these issues to fix: 1. Redundant pagination phrases (11 files):
2. Verbose creation phrases (19 files):
3. Verbose update phrases (30 files):
4. Compound words needing separation (8 files):
Total: 60 files need updates to make descriptions more concise and consistent. Working on fixes now...
Fixed in commit b625851: 60 files updated to remove redundant and verbose phrases:
All 439 endpoints now have concise, non-redundant descriptions following consistent patterns. |
…pound words Co-authored-by: AndyButland <[email protected]>
|
@copilot - from the last comment, please revert updates 3 and 4, i.e.:
These were better before the changes were made. Updates 1, 2 and 5 though were good. Please don't revert these. |
Co-authored-by: AndyButland <[email protected]>
Reverted in commit 1d63fb0. Create and Update controller descriptions now use the original verbose forms:
Kept the improvements for pagination phrases and compound words (11 files with pagination simplifications + 8 files with compound word fixes). |
Final Status
Successfully documented all 439 Management API endpoints (100% coverage) with consistent, clear descriptions.
Latest Changes (50 files reverted)
Reverted the simplification of Create and Update controller descriptions back to their original, more descriptive forms:
Reverted changes (now back to original):
Kept improvements from previous commit:
All descriptions now follow the original style guide with appropriate level of detail for Create/Update operations while removing only truly redundant pagination phrases.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.