Draft chore: improve ts components typo #1988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
先提交一部分代码，如果可行，我尽可能去统一 |
PeachScript
reviewed
Dec 16, 2023
| @@ -1,9 +1,12 @@ | |||
| import React, { type FC, type ReactNode } from 'react'; | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
我更倾向于保持 default and named exports，这样未来 react 如果有 esm 产物了，tree-shaking 是可以工作的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？/ What is the nature of this change?
🔗 相关 Issue / Related Issue
💡 需求背景和解决方案 / Background or solution
想把许多 React 代码风格统一一下，不知道有没有必要 （代码洁癖 2333~
📝 更新日志 / Changelog