FadeWorkS: Fix off-by-one error for \ko fades#25
Open
bucket3432 wants to merge 1 commit intounanimated:masterfrom
Open
FadeWorkS: Fix off-by-one error for \ko fades#25bucket3432 wants to merge 1 commit intounanimated:masterfrom
bucket3432 wants to merge 1 commit intounanimated:masterfrom
Conversation
`koko_da` determines the \ko duration by dividing the "Fade in" value by the number of word characters and punctuation if the "Fade in" value is at least 40. `len` contains the number of word characters and punctuation, but 1 is erroneously subtracted from it before the division, resulting in durations that are too long to fit the "Fade in" duration. The fix is to remove the subtraction and simply divide by `len`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
koko_dadetermines the \ko duration by dividing the "Fade in" value by the number of word characters and punctuation if the "Fade in" value is at least 40.lencontains the number of word characters and punctuation, but 1 is erroneously subtracted from it before the division, resulting in durations that are too long to fit the "Fade in" duration. The fix is to remove the subtraction and simply divide bylen.