-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Feat/docker PDF strategy #1518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
YorelN
wants to merge
21
commits into
unclecode:main
Choose a base branch
from
YorelN:fix/pdf-scraping-strategy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/docker PDF strategy #1518
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
9c6e016
fix: add scraping strategy for pdf
057fb61
fix: typo
5adc9dc
fix: add test suits
d231d61
fix: typo
c709082
fix: remove unused code
481e7fe
fix: remove broken test
726f41a
fix:remove deep crawl form tests
47bd392
fix: coderabbit recommendations
e17484f
test: avoid overriding url
94de653
fix: security & lint
bc3b3d1
fix: use safe callback
44b280b
fix: guards and consistency
21f80ff
fix: use jsonable_encoder
1636383
fix: timeout params
056721a
fix: http params
ec2f88a
fix: consistency
9681567
fix: missing check
87f35b8
fix: dedupe concurrent creators
2b80f98
fix: dedup race: non‑creator callers may double‑create and set the sa…
703243d
Revert "fix: use safe callback"
14994d8
fix: revert to initial
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include strategy configuration in the pool signature.
Keying pooled crawlers only by
crawler_strategy.__class__.__name__collapses all instances of the same strategy class into a single slot. If two callers supply the same strategy class with different constructor arguments (e.g.,PDFCrawlerStrategy(ocr=True)vsPDFCrawlerStrategy(ocr=False)), the second caller will be handed the already-started crawler that still holds the first instance, so their requested configuration is silently ignored. That’s a functional bug for any strategy with mutable/per-instance configuration. Please extend the signature to encode the strategy’s effective settings (e.g., module-qualified name plus a stable serialization of its config) so distinct instances don’t collide.🤖 Prompt for AI Agents