feat: add lint and fix commands to the Makefile#10
Open
Conversation
moliholy
force-pushed
the
feat/lint-fix
branch
from
a64d6b9 to
d66e550
Compare
moliholy
force-pushed
the
feat/lint-fix
branch
from
d66e550 to
20ce2cd
Compare
Member
Author
|
@OmeGak friendly ping. |
moliholy
changed the title
moliholy
force-pushed
the
feat/lint-fix
branch
from
056b04a to
3b892f0
Compare
moliholy
force-pushed
the
feat/lint-fix
branch
from
3b892f0 to
bd7c067
Compare
Ensures ruff, python, isort and other venv binaries are available directly, which is needed by indico's pre-commit hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
make lintandmake fixcommands that emulate the CI checks indico core follows, scoped to only changed files in the indico submodule. Covers Python (isort, unbehead, ruff) and JS/CSS (biome, eslint, tsc, stylelint) tooling.Also adds the virtualenv to PATH via direnv so that indico's pre-commit hook can find the required binaries (ruff, python, isort).