Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #47

Open
wants to merge 170 commits into
base: main
Choose a base branch
from
Open

Dev #47

wants to merge 170 commits into from

Conversation

mivanit
Copy link
Member

@mivanit mivanit commented Feb 11, 2025 •
edited
Loading

a continuation of #46

Enhance maze generation functionality by introducing the ability to handle cases where maze generation fails. Previously, an unsolvable maze would cause an error and halt the process. With this update, such problematic mazes are gracefully handled by excluding them from the dataset instead of raising an error.

TODO:

  • fix edits from Improve Maze Generation by Skipping Unsolvable Mazes #46
  • new makefile, switch to uv from poetry
  • progressive type hinting
    • tool to tell us how many errors per file
  • estimating dataset success fraction
    • sweeping over configs
    • plots for success rate over various configs
    • pysr for fitting a function to the above
    • restructure SweepResult to not depend on consistent hashes?
    • page for plots in docs, reorganize the docs/benchmarks folder
    • make recipe for config sweep and fit, test it in CI
  • include the fname in MazeDatasetConfig.serialize()
    • use a more stable hashing system
    • put fname in the hash
  • checks passing

bknutson0 and others added 28 commits December 21, 2024 23:15
@bknutson0
test code
0aaf8fd
@bknutson0
remove ruff dependency
bd22283
@bknutson0
ignore .DS_Store files
e986d58
@bknutson0
Merge branch 'improve-maze-generation' of github.com:bknutson0/maze-d…
06d203e 
…ataset into improve-maze-generation
@bknutson0
create notebook to generate relevant error
07dad03
@bknutson0
move error producing notebook outside notebooks folder to so that Che…
a260481 
…cks do not fail
@bknutson0
continue modifying notebook to clarify error generation
b27b537
@bknutson0
continue improving maze generation by adding NoValidEndpointException…
54c0d47 
… and associated handling
@bknutson0
fix unit test, which should now expect NoValidEndpointException inste…
a4081cc 
…ad of ValueError
@bknutson0
fix import order, to satisfy isort during Check
c193791
@bknutson0
use isort directly
d494013
@bknutson0
run black on files directly to pass black Check
3578c5e
@bknutson0
begin filtering None values corresponding to unsolvable mazes generat…
5a2c88a 
…ed when except_on_no_valid_endpoint=False
@bknutson0
successfully filter None values from maze dataset
77dfdee
@bknutson0
run isort and black to properly format
8b83185
@bknutson0
remove helper notebooks used for debugging
277321b
@bknutson0
add temporary setup file to allow for local installation
3cdf910
@mivanit
Merge pull request #46 from bknutson0/improve-maze-generation
5191d28 
temporary merge into dev

Improve Maze Generation by Skipping Unsolvable Mazes
@mivanit
remove setup.py
6dba7c6
@mivanit
revert some comment/docstring changes
1ed515b
@mivanit
add back a print statement in tests
b2df44c
@mivanit
revert some minor changes
17f2eb4
@mivanit
rework handling of except_on_no_valid_endpoint
ba09297 
- it stays in the `endpoint_kwargs`, but is actually passed to `generate_random_path`
  which now returns `None` if `except_on_no_valid_endpoint` is `False` and it fails to find endpoinhts

- removed `except_when_invalid`, but we reuse the logic which existed for it
@mivanit
make format
94a5852
@mivanit
remove --check from poetry lock in CI -- we will be replacing with uv…
5f2c5a2 
… anyway
@mivanit
update poetry lock ugh
eb0edf1
@mivanit
dont assert type with new muutils
569630f
@mivanit
fixed bug with not getting endpoint kwargs
3f136c0
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mivanit and others added 30 commits February 23, 2025 19:33
@mivanit
re-run nb
7037dcf
@mivanit
generate benchmarks
58dd281
@mivanit
wip
1ff6183
@mivanit
make format
abb43fd
@mivanit
medium and large runs
f4844ae
@mivanit
make hash more stable
e788f93
@mivanit
make format
b752a46
@mivanit
pysr run
333e751
@mivanit
export sweep_fit into module with cli
4575023
@mivanit
updates to sweep_fit
f8cff7c
@mivanit
wip
6440714
@mivanit
data?
e7f8dd1
@mivanit
make format
fd995f8
@mivanit
update pysr kwargs
f750e3b
@mivanit
makefile fix
49a58f2
@mivanit
format
8f27421
@bknutson0
change import of GLOBAL_SEED and DEFAULT_SEED to avoid making local c…
0d31511 
…opies
@mivanit
??
635b725
@mivanit
better function fit
fbe6abd
@mivanit
wip
042ea55
@mivanit
fix nb and code!
3ca6e5f
@mivanit
make format
7f6c859
@mivanit
Merge branch 'dev' of https://github.com/understanding-search/maze-da…
5105446 
…taset into dev
@mivanit
wip
07df9a3
@mivanit
make dep
2812a0d
@mivanit
swap order of gen funcs?
abfd470
@mivanit
revert fix oops
41d4045
@mivanit
patch for config we didnt train on
c6f013d
@mivanit
run notebook
f1064ce
@mivanit
make format
ed0da28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mivanit @bknutson0