Skip to content

Conversation

@btangmu
Copy link
Member

@btangmu btangmu commented Oct 14, 2025

-One line was moved in common/dtd/ldmlSupplemental.xsd by running GenerateDTD

CLDR-18435

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@AEApple
Copy link
Contributor

AEApple commented Oct 14, 2025

Why do lines move?

srl295
srl295 previously approved these changes Oct 15, 2025
@srl295
Copy link
Member

srl295 commented Oct 15, 2025

oh - this needs to target maint-48

@srl295
Copy link
Member

srl295 commented Oct 15, 2025

Why do lines move?

because the attribute was reordered

@srl295 srl295 changed the base branch from main to maint/maint-48 October 15, 2025 23:58
@srl295 srl295 dismissed their stale review October 15, 2025 23:58

The base branch was changed.

@srl295 srl295 changed the base branch from maint/maint-48 to main October 15, 2025 23:58
srl295
srl295 previously approved these changes Oct 15, 2025
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please rebase/reapply to maint-48

@btangmu btangmu changed the base branch from main to maint/maint-48 October 19, 2025 13:46
@btangmu btangmu dismissed srl295’s stale review October 19, 2025 13:46

The base branch was changed.

@btangmu
Copy link
Member Author

btangmu commented Oct 19, 2025

I will redo from maint-48

@btangmu
Copy link
Member Author

btangmu commented Oct 19, 2025

See #5146

@btangmu btangmu deleted the t18435_c branch October 19, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants