CLDR-16855 Survey Tool account creation date #5145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-New column firstdate in db cldr_users table, add and populate if not present when ST starts up -Already existing users get approximate dates based on the first versions in which they voted, according to vote tables from version 25 and later; users who never voted get null meaning unknown -When new user accounts are added, firstdate will get the creation date -Display as (account created ...) in Account Settings, with indication if approximate or unknown -Rename Java User.last_connect to User.lastlogin for consistency with lastlogin in db cldr_users table -New convenience function DBUtils.addColumnIfMissing; slightly refactor STFactory to use it -Change some items in UserRegistry from public to private -Minor edits for consistency, such as uppercase for SQL keywords -Fix recently added bug in cldrAddUser.mjs and cldrAddUser.mjs: set orgName if not admin -Comments
-Fix comments and a variable name
srl295
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-New column firstdate in db cldr_users table, add and populate if not present when ST starts up
-Already existing users get approximate dates based on the first versions in which they voted, according to vote tables from version 25 and later; users who never voted get null meaning unknown
-When new user accounts are added, firstdate will get the creation date
-Display as (account created ...) in Account Settings, with indication if approximate or unknown
-Rename Java User.last_connect to User.lastlogin for consistency with lastlogin in db cldr_users table
-New convenience function DBUtils.addColumnIfMissing; slightly refactor STFactory to use it
-Change some items in UserRegistry from public to private
-Minor edits for consistency, such as uppercase for SQL keywords
-Fix recently added bug in cldrAddUser.mjs and cldrAddUser.mjs: set orgName if not admin
-Comments
CLDR-16855
ALLOW_MANY_COMMITS=true