Skip to content

Reclassifying ERRORS in data generation - see issue #238 #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Reclassifying ERRORS in data generation - see issue #238 #525

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb2cbab
Reclassifying ERRORS in data generation - see issue #238
sven-oly Sep 24, 2024
bb879c8
Change exception type
sven-oly Sep 6, 2025
66bd66b
Fix type of exceptions
sven-oly Oct 9, 2025
20a940e
merging
sven-oly Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions testgen/generators/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,15 @@ def generateTestHashValues(self, testdata):

try:
all_tests = testdata['tests']
except BaseException as error:
except Exception as error:
logging.error('# generateTestHashValues: %s does not have "tests": %s',
error, testdata.keys())
return None

for test in all_tests:
try:
test_no_label = test.copy()
except BaseException as error:
except Exception as error:
logging.error('error: %s, Item with no label found here: %s, %s' ,
error, testdata['test_type'], test)
continue
Expand Down Expand Up @@ -108,7 +108,7 @@ def getTestDataFromGitHub(self, datafile_name, version):
)
return None
return r.text
except BaseException as err:
except Exception as err:
logging.warning(
"Warning: cannot load data %s for version %s. Error = %s",
datafile_name,
Expand Down Expand Up @@ -136,7 +136,7 @@ def readFile(self, filename, version="", filetype="txt"):
try:
with codecs.open(path, "r", encoding="utf-8") as testdata:
return json.load(testdata) if filetype == "json" else testdata.read()
except BaseException as err:
except Exception as err:
logging.warning("** readFile: %s", err)
return None

Expand Down
Loading